Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-220514893
@sanju1010 ping...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-219726178
@sanju1010 unfortunately I can not get this into 4.9 with the current bug
in it. I am willing to test this and try to get it in if you fix the issues,
but we are in
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-218813851
@sanju1010 can you please review this? I am not worried about the issue
with `` because I have verified that issue already existed. However, the
following problem s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-215548871
@sanju1010 please review the CI run results when you have a second.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-213841496
Please review the details of the CI run. I am using a KVM
[bubble](https://github.com/MissionCriticalCloud/bubble-toolkit) to test this
and I have not tried to manua
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-213841009
### CI RESULTS
```
Tests Run: 9
Skipped: 0
Failed: 0
Errors: 2
```
**Summary of the problem(s):**
```
ER
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-206440627
Just got my CI back up and running. I will be getting it running against a
few PRs ASAP.
---
If your project is set up for it, you can reply to this email and have
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-206296119
@swill, did you get a chance to run CI on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-197551390
I will test this as soon as my CI is up and running. If anyone else has
had a chance to test this and can post the results I will merge it right away.
Thx...
---
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-196797692
LGTM. one remark out of scope: let's consider externalizing the urls to
facilitate handling such issues in the future.
---
If your project is set up for it, y
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-196152972
Doesn't seem to be much of a code(functionality) change. The changes made
in testdata.py LGTM !!
---
If your project is set up for it, you can reply to this emai
11 matches
Mail list logo
