[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-28 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1370#discussion_r51006290 --- Diff: engine/api/pom.xml --- @@ -38,7 +38,7 @@ org.apache.cxf cxf-bundle-jaxrs - 2.7.13 + 2.7.18

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1370#discussion_r51005339 --- Diff: engine/api/pom.xml --- @@ -38,7 +38,7 @@ org.apache.cxf cxf-bundle-jaxrs - 2.7.13 + 2.7.1

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175523813 @bhaisaab if we make the packaging require Java 1.8, then users will be automatically upgraded -- defeating the purpose of the deprecation. It seems like an appro

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175492873 Alright, let's keep this PR hanging then. We should then open another PR which fixes the packaging first to switch from JRE7 to JRE8 along with any JAVA_OPT or tom

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175490258 To ease transition, it seems like the first step should be to support running ACS built to 1.7 on a 1.8 runtime. This approach would allow customers unprepared to

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175477214 @wido I was getting some compilation issue specifically to F5, to which someone previously on ML had advised an issue related to dependency version so I've include

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-27 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175473551 I agree with switching to Java 8, but shouldn't this be a small PR first where we ONLY switch to Java 8? Other PRs can follow up quickly. --- If your project

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

2016-01-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1370#issuecomment-175328669 cc @DaanHoogland @jburwell @wido @wilderrodrigues @remibergsma @borisroman and others --- If your project is set up for it, you can reply to this email and have