Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163977752
Not sure what happened, the test passes fine now. LGTM.
```
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163967401
We used separate environment, but provided by the same infra.
What I don't get is why the tests are being executed from
```/data/git/cs1/cloudstack/
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163896132
@remibergsma @wilderrodrigues @DaanHoogland
I guess you tested in the same env, right?
It might be a network issue, eg DNS or Ipv6 ?
---
If your projec
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163883953
Guys, I think (and hate myself for bringing it up again despite my
intentions not to) you are giving an argument to merge MCT-shared#20 I use the
merge procedu
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163865197
@wilderrodrigues @ustcweizhou I can confirm that tests fails for me too,
even when I rebased before testing it.
```
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163604337
That's odd! :(
Same test was executed by @remibergsma and I this week and everything went
fine.
But if that was rebased, the test should no
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163579922
I reran the test and it failed again:
```
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false |
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163560328
LGTM Tested the actual feature:
Created a VPC:
 says:
Test redundant router internals ... === TestName:
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163539316
Did the regression tests:
[1197.network.results.txt](https://github.com/apache/cloudstack/files/57825/1197.network.results.txt)
[1197.vpc.results.txt](
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163538722
You are right @ustcweizhou . My branch was not up to date. Applied the
patch on latest master.
- Able to see vpcname and vpcid in listRouters response
-
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163519772
@kishankavala Thanks for review.
This PR should be able to be applied on master, as I do not see the
following eror on this page
"This branch has co
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163492909
@ustcweizhou Changes look good to me. But I could not actually test them,
patch doesn't apply on latest master
---
If your project is set up for it, you can r
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1197
[4.7] CLOUDSTACK-9129: list vpc routers by keyword in Infrastructure ->
Virtual Routers
and two more changes:
(1) add network name/vpc name in the listRouters response
(2) add
17 matches
Mail list logo
