[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-29 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r46089078 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final Dedic

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-27 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r46066286 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final Dedic

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-23 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r45596255 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final Dedic

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-23 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r45595780 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final Dedic

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

2015-11-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1007#issuecomment-158914722 Repeated the tests due to new commits: LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advan