[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2016-05-30 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-222566382 ### ACS CI BVT Run **Sumarry:** Build Number 92 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3 _L

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-216197872 @karuturi please rebase against master and push -f, and update on status of your PR, thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2016-04-28 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-215366187 @karuturi Any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2016-01-13 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/928#discussion_r49688571 --- Diff: server/src/com/cloud/template/TemplateAdapterBase.java --- @@ -293,9 +298,15 @@ public TemplateProfile prepare(GetUploadParamsForTemplat

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2015-11-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/928#issuecomment-153688197 LGTM (just code review, no testing performed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/928 [4.7] CLOUDSTACK-8950 Hypervisor Parameter check is not performed for registerTemplate and getUploadParamsForTemplate API's Any string is allowed as hypervisor type from the api. Hypervisor