Github user ustcweizhou closed the pull request at:
https://github.com/apache/cloudstack/pull/1027
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-156212332
@wido sure , closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-156161390
@ustcweizhou Could you close this PR? #985 has some new patches which use
libvirt. Some of your code also went in there :)
---
If your project is set up for it, you c
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-155054417
I've just send a patch upstream to libvirt-java so that we can use Libvirt
for sending commands to Instances:
https://www.redhat.com/archives/libvir-list/2015-November
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-155008717
Great stuff, +1 for having the channel enabled by default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-155004607
I'm going to take a look at this via @borisroman today.
I'm also working on a patch for libvirt-java, since using those bindings
you can also send Qemu Guest A
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-154405884
@wido thanks for your review. good to hear that.
There are 5 commits by me in this PR. You can cherry-pick the commits you
need to your branch and continue y
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-154403884
@ustcweizhou I looked at the code more closely and it looks good.
However, I would still vote for having the Agent port always enabled. This
saves a lot of cod
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153681436
@wido @sspans
To be honest, this code was written by me about two years ago , which is
not used for now. I created the PR because you guys can judge this co
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153674330
@ustcweizhou Ah, I see indeed.
So the discussion is:
- Do we enable the port by default? I would say yes. (Less code!)
- Do we enable the port for SSVMs
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153672795
@wido this PR already includes your commits in #985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153668057
So I wrote #985 which adds a channel by default to all guests. The question
is, how do we proceed. Which one goes in?
---
If your project is set up for it, you can re
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153667850
@sspans Indeed. Users can stop/disable the agent or even block specific
commands if they wish to. As CloudStack we don't control what's in the
Instance, so it's the us
Github user sspans commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153667126
Consistent Snapshots are not possible without freeze/thaw via the
guest-agent.
I think most people want good snapshots of their virtual machines.
That sa
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153664875
@ustcweizhou I don't see the difference personally, as a admin you already
have full access to the Instance if you want to.
But this PR conflicts with mine, th
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153664020
ran the regression set with some f
```nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/t
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153404172
The virtio console is a bridge between hypervisor and vm instance. I am not
sure if customers feel good/friendly with this.
I donot know if libvirt-java
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1027#issuecomment-153370288
Overall this seems OK, but I personally think that we can enable it by
default on all KVM guests. It doesn't hurt to add the port.
We can detect if the port is
18 matches
Mail list logo
