[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-19 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-158116184 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-19 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-158051578 @remibergsma: some time to re-run the tests? Need a 2nd LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-19 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-158036108 @miguelaferreira @remibergsma @wilderrodrigues LGTM :+1: ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cf

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-18 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-157764335 Ping @miguelaferreira @remibergsma Tests are fine, but of course we can only be sure if they work with you as well. There was also a last

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-18 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-157655322 Although it’s based on an assumption, enforced by good pattern recognition, what happened to @miguelaferreira and @remibergsma was: 1. the code d

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-18 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-157651712 @remibergsma and @miguelaferreira faced problems related to SSH timeout whilst testing this PR. I retested it and did not face the same issue: ```

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-17 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-157373768 Ping @remibergsma Are the tests still running? Cheers, Wilder --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues closed the pull request at: https://github.com/apache/cloudstack/pull/1064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156974109 Please have a look at #1070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-156960642 @wilderrodrigues Starting my tests.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156960593 Please close this PR, as will get #1070 in now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-156957978 Ping @remibergsma PR against 4.6 has been created. No we need people to review/test it. Cheers, Wilder --- If your project is set up

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1070 [4.6.1] CLOUDSTACK-9015 - Redundant VPC Virtual Router's state is BACKUP & BACKUP or MASTER & MASTER This PR closes #1064 All the details can be found in the original PR, which

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-15 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156827648 @wilderrodrigues Can you please make this PR against 4.6 instead of master? It will then be included in 4.6.1 and also be merged forward to master. --- If your

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-12 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156337467 Jenkins failed due to artifact transfer error: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.3:pro

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-12 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156336955 Ping @remibergsma @karuturi @giraffeforestg @borisroman @bhaisaab @miguelaferreira @DaanHoogland More test results: * Management Server +

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-12 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156253559 @wilderrodrigues Thanks for fixing! Will run tomorrow or this weekend. --- If your project is set up for it, you can reply to this email and have your reply appe