[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-160442447 Functionality also works: ``` (local) � > list vlanipranges keyword=50 count = 1 vlaniprange: id = abdc0be9-6869-438b-9b10-16061bd0bdcb

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-160442363 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-158874483 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-18 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-157652943 OK, please double check is always necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-18 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-157647900 This time you tested and showed us how to do it. Good! The code LGTM, but I will also run the same test on this PR. Cheers, Wilder ---

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

2015-11-17 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1085 [4.6] Cannot list vlanipranges by keyword Before change: cloudmonkey> list vlanipranges keyword=118 : Caught: com.mysql.jdbc.JDBC4PreparedStatement@18f36b6e: SELECT vlan.id, v