[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...

2015-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...

2015-12-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1182#issuecomment-164146578 LGTM based on the code. It does implement a use case that should be tested. not sure if we need it in this PR --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1182#issuecomment-162850730 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_