Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160576751
great @bhaisaab I'll create the merge forward
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160574861
Merging now that we're tests performed and 2LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160559759
LGTM based on the code. I don't see any real issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160514198
Verifying this is simple, just check the in the VM's virt xml
(virsh edit domain, note the serial in the xml for the disk/volume) and ssh
into the VM and check th
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089207
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -761,6 +766,10 @@ public String toString() {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089189
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -761,6 +766,10 @@ public String toString() {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089183
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -419,7 +419,7 @@ public String toString() {
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1121#discussion_r46089169
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -419,7 +419,7 @@ public String toString() {
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160390932
Pinging @DaanHoogland @borisroman to do second review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160390678
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1121#issuecomment-160287951
Ping @wido @wilderrodrigues @remibergsma
Related: https://github.com/apache/cloudstack/pull/1120
---
If your project is set up for it, you can reply to this em
12 matches
Mail list logo
