[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152205902 @remibergsma just checked this does not apply for 4.5, 4.5 has no prefilter in that section (see screenshot on 4.5) ![screen shot 2015-10-29 at 8 25 52

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152203911 @remibergsma good idea, will do thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152202839 Ping @bhaisaab you may want to backport this small fix to 4.5 --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152201239 LGTM as well! 

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152187750 Ping @remibergsma @DaanHoogland @borisroman @wido @miguelaferreira Thanks, @karuturi! :) LGTM :+1: Test results: * Hardware req

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152148763 Hi @karuturi It worked! I removed the files under Jetty cache, stopped the management server, run mvn clean install again and restarted it.

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152148071 @wilderrodrigues can you clear browser cache (cmd +shift + del in firefox) or reload the page without cache using shift+f5 and then try? --- If your project is se

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152145661 Ping @karuturi @remibergsma I delete the Jetty cache and restarted the Management Server, but still did not get the new item on the list. C

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152138363 Ping @karuturi Testing your PR, but when I checked the UI I still got the old list: no VPC offering. Do I need to change anything else in order to g

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152131926 Ping @karuturi @remibergsma @miguelaferreira Code LGTM, because it's very simple. But I will run our set of tests agains this PR - although it menti

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152124858 @karuturi @remibergsma This is the second PR I look into and find that Travis is nor running any Marvin tests! As I said in PR #997, fire few Travis

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-151803068 @karuturi Thanks! Will test soon :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/996 [4.6] CLOUDSTACK-8984: VPC Network offerings tab missing from UI This is a regression from commit af2f21894ce061faadc8cec29b901719303a29dc added vpcofferings to the select list