Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-164165606
@DaanHoogland thanks for merging. This is not yet in 4.5 as I'm yet to
merge the 4.5 based PR https://github.com/apache/cloudstack/pull/1131
Will do that on Mon
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-164150715
code LGTM and @remibergsma his test succeed, as this is in 4.5 I think it
must go in 4.6 as well, however it contains way to little tests and can not be
guaran
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160903184
Ping @abhinandanprateek @borisroman @jburwell @pdion891 and others for
review
---
If your project is set up for it, you can reply to this email and have your
rep
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160561489
@sateesh-chodapuneedi this is a real bug for many users as they are not
able to use Windows 2012 templates with vmware/CloudStack, which is why we need
the fix in
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160517214
@bhaisaab why are we merging the feature branch into a 4.6.*
maintenance/minor release branch. Shouldn't it be merged into a major release
branch/maste
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160514080
Thanks @remibergsma
Ping @sateesh-chodapuneedi can you review this, and later if you want sent
additional PRs with further changes etc.
---
If your project i
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160443626
@bhaisaab Let's find someone else who can review this..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1132#issuecomment-160392997
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1132
[4.6] CLOUDSTACK-4787 - vmware diskcontrollers
Same as #1131 (see this for screenshots etc)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
10 matches
Mail list logo
