Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162340165
lgtm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162286626
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161922013
@remibergsma okay, I found what Github did in my case: when you select the
second branch dropdown while create a PR it resets the first dropdown branch to
master
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1175
[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit
tests
Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161921440
@remibergsma thanks, not sure why this happened again. This was supposed to
be for 4.6, will recreate a new PR. I'm not sure on how to test it, it's just
that Jenk
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1171#issuecomment-161920716
@bhaisaab How can I help testing this? Also, your branch mentions 4.6 but
the PR is made against master branch. Is that correct? Just checking ;-)
---
If your
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1171
[4.6/master] rate-limit: increase JVM memory and enable fork mode for unit
tests
Enables forkmode for surefire plugin and increases memory opts for JVM
for rate-limit tests. This tries to
