Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161898597
@remibergsma thanks, opened another PR #1169 please merge that. Closing
this one, as once the other PR will be merged on 4.6 and 4.6 on master; we
won't need this
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161885184
@bhaisaab Check! This I cannot merge to 4.6 with this PR so if you make one
against 4.6 that would be easy. Mention this one so it can go through faster.
Thanks
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161878014
@remibergsma let me know if you want me to open a new PR against 4.6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161877977
@remibergsma sorry for the source/target branches; this needs to go into
both 4.6 and master branches. So merge on 4.6, and fwd-merge 4.6 on master.
Thanks.
---
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161748134
@bhaisaab Should I merge this to master, or should it be merged to 4.6?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161709051
Seems good, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161437830
Ping @borisroman to have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161429236
Makes sense, LGTM also based on the successful job above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1149#issuecomment-161216838
Test jenkins build job:
http://sb.bhaisaab.org:/job/deb-shapeblue-build-patch-noredist/103/console
---
If your project is set up for it, you can reply to this
10 matches
Mail list logo