Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206462240
Ok, thanks @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206461873
@rafaelweingartner mea culpa, I used the older git pr tool and pushed it.
AFAIK our current process and details of reviewing, testing and merging PRs is
not voted
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206425673
Do you mean that the need for 2LGTMs was voted after this PR was open? It
seems that it was a direct commit. Why did you not use the merge tool?
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206423048
@rafaelweingartner more of a guidelines, this was never voted on and this
does not apply for 4.5; there is an outstanding PR for recent branches
---
If your proje
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-206358834
@bhaisaab, @swill,
Was this PR merge or closed?!?
I noticed a merge to the code base, but this PR did not have the 2LGTMs
that it would need to be
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-198578324
### ACS CI BVT Run
**Sumarry:**
Build Number 112
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=13
Skipped=4
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-188224889
@cristofolini I think you're right, both Travis and Jenkins are having
inconsistent builds. While I could refactor the method in its own method, I
don't see if it
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-183970215
@bhaisaab Did you get to see the output of the jenkins build? Was it just
another false positive? I don't see anything in the code that could cause it to
fail.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-180481369
VM tests performed manually on 4.5+patch:
1. Started Windows 2012 Template on the newly patched 4.5.2
Windows 2012 Root drive was set too IDE (0:1)
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1366
[4.5] vmware: improve support for disk controllers
- Improve disk chain usage while attaching, migrating disks
- Gets root disk controller based diskDeviceBusName from volume's chain info
11 matches
Mail list logo
