[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111591078 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest req, final HttpSe

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111589656 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletRes

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111589706 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletRes

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111589627 --- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java --- @@ -28,6 +28,8 @@ "API end point. Can be used by CS compon

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111589567 --- Diff: core/src/com/cloud/network/HAProxyConfigurator.java --- @@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final LoadBalancerTO lbTO) {

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111568831 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest req, final HttpSe

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111568764 --- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java --- @@ -28,6 +28,8 @@ "API end point. Can be used by C

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r11156 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest req, final HttpSe

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2046#discussion_r111568225 --- Diff: core/src/com/cloud/network/HAProxyConfigurator.java --- @@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final LoadBalancerTO

[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...

2017-04-14 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/2046 CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls The global setting 'management.admin.cidr' is set to 0.0.0.0/0,::/0 by default preserve the current behavior and thus a

[GitHub] cloudstack pull request #2045: Fix snmptrap alert bug

2017-04-14 Thread WingkaiHo
GitHub user WingkaiHo opened a pull request: https://github.com/apache/cloudstack/pull/2045 Fix snmptrap alert bug Fix snmptrap alerts info omit to send the field of SnmpConstants.sysUpTime. So when standard snmptrapd receive alerts package the field OID will dislocation

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-14 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/2030 WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/clouds

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-14 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/2030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/2044 CLOUDSTACK-9877 Cleanup unlinked templates This implements CLOUDSTACK-9877 by marking templates for gc when 1. the template they where created with is deleted from cloudstack 2. all

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-04-13 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre… …ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git reposi

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1282#discussion_r111531779 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -245,6 +245,12 @@ public boolean

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-04-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request #2043: CLOUDSTACK-9876: Removed test test_01_test_vm...

2017-04-13 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/2043 CLOUDSTACK-9876: Removed test test_01_test_vm_volume_snapshot As we no longer have that restriction and now after fix for CLOUDSTACK-8663 we allow VM and volume snapshots to exist together

[GitHub] cloudstack pull request #2042: CLOUDSTACK-9875: Unable to re-apply Explicit ...

2017-04-13 Thread harikrishna-patnala
GitHub user harikrishna-patnala opened a pull request: https://github.com/apache/cloudstack/pull/2042 CLOUDSTACK-9875: Unable to re-apply Explicit dedication to VM Problem: When a VM is deployed with in an Affinity group which has the cluster dedicated to a subdomain (zone is de

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1950 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2033: [master/4.10+] CLOUDSTACK-9462: Support for U...

2017-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgra...

2017-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-13 Thread Slair1
Github user Slair1 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1282#discussion_r111500346 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -245,6 +245,12 @@ public boolean dele

[GitHub] cloudstack pull request #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with m...

2017-04-13 Thread sudhansu7
Github user sudhansu7 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/914#discussion_r111375928 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -3206,25 +3206,33 @@ public long ge

[GitHub] cloudstack pull request #2041: CLOUDSTACK-9873: VR related periodic jobs are...

2017-04-12 Thread Slair1
GitHub user Slair1 opened a pull request: https://github.com/apache/cloudstack/pull/2041 CLOUDSTACK-9873: VR related periodic jobs are scheduled twice and run twice on management servers The "start" method of VirtualNetworkApplianceManagerImpl schedules several period checks, inclu

[GitHub] cloudstack pull request #2040: CLOUDSTACK-9872: Gather all S2S vpn statuses ...

2017-04-12 Thread Slair1
GitHub user Slair1 opened a pull request: https://github.com/apache/cloudstack/pull/2040 CLOUDSTACK-9872: Gather all S2S vpn statuses before outputting The checkbatchs2svpn.sh VR script returns ("via echo") that status of each requested S2S VPN check one-at-a-time. If there is even

[GitHub] cloudstack pull request #2039: rbd: Use libvirt to create new volumes and no...

2017-04-12 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/2039 rbd: Use libvirt to create new volumes and not rados-java Since libvirt 1.2.2 libvirt will properly create volumes using RBD format 2. We can use libvirt to creates the volumes which s

[GitHub] cloudstack pull request #2038: ipv6: Allow all ICMPv6 traffic if -1 is provi...

2017-04-12 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/2038 ipv6: Allow all ICMPv6 traffic if -1 is provided as a ICMP type ip6tables no longer takes '--icmpv6-type any' as a argument. To allow all ICMPv6 traffic with ip6tables it has to be invoked

[GitHub] cloudstack pull request #2033: [master/4.10+] CLOUDSTACK-9462: Support for U...

2017-04-12 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/2033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2033: [master/4.10+] CLOUDSTACK-9462: Support for U...

2017-04-12 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/2033 [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16.04 with tomcat6/tomcat7 This extends work from @ustcweizhou from https://github.com/apache/cloudstack/pull/1950 by fixing some build

[GitHub] cloudstack pull request #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session ...

2017-04-12 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/2037 CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility MySQL 5.7 has a more strict SQL mode by default with which CloudStack is not compatible. By setting the SQL Mod

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

2017-04-12 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r111075302 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java --- @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foun

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

2017-04-12 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r111075076 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java --- @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foun

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

2017-04-12 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r111078382 --- Diff: server/src/com/cloud/api/ApiDBUtils.java --- @@ -559,6 +561,8 @@ @Inject private VpcManager vpcMgr; @Inject

[GitHub] cloudstack pull request #1740: CLOUDSTACK-9572 Snapshot on primary storage n...

2017-04-11 Thread yvsubhash
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #2025: [4.10-blocker] Fix error in restart network i...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2025 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2022: [dvswitch blocker] CLOUDSTACK-9591: Fix syste...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2036: [CLOUDSTACK-9858] Retirement of midonet plugi...

2017-04-11 Thread rafaelweingartner
GitHub user rafaelweingartner opened a pull request: https://github.com/apache/cloudstack/pull/2036 [CLOUDSTACK-9858] Retirement of midonet plugin (build disabling) Recently there have been two threads asking and discussing the “midonet” integration with Apache CloudStack (ACS)

[GitHub] cloudstack pull request #1721: CLOUDSTACK-9557 Deploy from VMsnapshot fails ...

2017-04-11 Thread yvsubhash
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/1721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop...

2017-04-11 Thread yvsubhash
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854129 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final Publ

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854097 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v.i

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854055 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v.i

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110848750 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110849362 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final P

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110848709 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-10 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110818988 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected Execut

[GitHub] cloudstack pull request #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellan...

2017-04-10 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1826 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-10 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2026#discussion_r110594291 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL) AND

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-07 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r110421451 --- Diff: server/test/com/cloud/user/DomainManagerImplTest.java --- @@ -134,4 +164,69 @@ public void testFindDomainByIdOrPathValidId() { As

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-07 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r110421376 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +284,145 @@ public boolean deleteDomain(long domainId, Boolean cleanup) {

[GitHub] cloudstack pull request #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allo...

2017-04-07 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/2034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allo...

2017-04-07 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/2034 [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs This enables the firewall/mangle tables rules to ACCEPT instead of RETURN, which is the same b

[GitHub] cloudstack pull request #2035: CLOUDSTACK-9867:VM snapshot on primary storag...

2017-04-07 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2035 CLOUDSTACK-9867:VM snapshot on primary storage usage metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack

[GitHub] cloudstack pull request #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allo...

2017-04-07 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/2034 [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs This enables the firewall/mangle tables rules to ACCEPT instead of RETURN, which is the same beh

[GitHub] cloudstack pull request #2033: [Ignore] Test PR

2017-04-06 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/2033 [Ignore] Test PR See https://github.com/apache/cloudstack/pull/1950 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ubun

[GitHub] cloudstack pull request #2032: CLOUDSTACK-9783: corrected the version number...

2017-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2032 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2032: CLOUDSTACK-9783: corrected the version number...

2017-04-06 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/2032 CLOUDSTACK-9783: corrected the version number in metrics pom master is broken after fwd-merging metrics PR #1944 from 4.9 This is due to the incorrect parent version number in the metrics p

[GitHub] cloudstack pull request #2031: CLOUDSTACK - 8672 : Test PR

2017-04-06 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/2031 CLOUDSTACK - 8672 : Test PR Currently running with few commit. Please don't review this PR. According to the result of this PR, I will update in original PR(1859). You can merge this

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-04-06 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1889 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-04-06 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1889 CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for migration in a Zone Refer to [CLOUDSTACK-9718](https://issues.apache.org/jira/browse/CLOUDSTACK-9718) for more

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2030#discussion_r110145877 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -550,15 +552,21 @@ public boolean

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2030#discussion_r110145761 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -128,6 +129,7 @@ public class

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-06 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110113725 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected Exe

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110112007 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final Publ

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r11089 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final Publ

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/2030 WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudsta

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-06 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2026#discussion_r110098624 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL) AND -- CL

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2029 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

2017-04-06 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2029 CLOUDSTACK-9857: With this change if agent dies the systemd will catc… …h it properly and show process as exited You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-06 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1282#discussion_r110092518 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -245,6 +245,12 @@ public boolean delet

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-06 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1282#discussion_r110092478 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -245,6 +245,12 @@ public boolean delet

[GitHub] cloudstack pull request #1880: CLOUDSTACK-9720: [VMware] template_spool_ref ...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1880 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-05 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110082664 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1764,9 +1765,12 @@ protected ExecutionRe

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-05 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110082657 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected Execut

[GitHub] cloudstack pull request #2028: CLOUDSTACK-9853: Add support for Secondary IP...

2017-04-05 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/2028 CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets This commit adds support for passing IPv6 Addresses and/or Subnets as Secondary IPs. This is groundwork for CLOUDS

[GitHub] cloudstack pull request #2027: Activate NioTest following changes in CLOUDST...

2017-04-05 Thread marcaurele
GitHub user marcaurele opened a pull request: https://github.com/apache/cloudstack/pull/2027 Activate NioTest following changes in CLOUDSTACK-9348 PR #1549 The first PR #1493 re-enabled the NioTest but not the new PR #1549. @rhtyd the test fails locally on my laptop. Is ther

[GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...

2017-04-05 Thread SudharmaJain
Github user SudharmaJain commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/876#discussion_r109859606 --- Diff: plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java --- @@ -3

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

2017-04-04 Thread kishankavala
Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r109835294 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public st

[GitHub] cloudstack pull request #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-04 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2026 CLOUDSTACK-9861: Expire VM snapshots after configured duration Default value of the account level global config vmsnapshot.expire.interval is -1 that conforms to legacy behaviour

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-04 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r103529571 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,82 +284,145 @@ public boolean deleteDomain(long domainId, Boolean clean

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-04 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r102538324 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -109,6 +112,20 @@ @Inject MessageBus _messageBus;

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-04 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r103529869 --- Diff: server/test/com/cloud/user/DomainManagerImplTest.java --- @@ -134,4 +164,69 @@ public void testFindDomainByIdOrPathValidId() {

[GitHub] cloudstack pull request #2020: WIP: Expire VM snapshots

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-04-04 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r109633875 --- Diff: debian/control --- @@ -16,14 +16,15 @@ Description: A common package which contains files which are shared by several C Package: clou

[GitHub] cloudstack pull request #2025: Fix error in restart network in 4.10.0.0 RC

2017-04-04 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/2025 Fix error in restart network in 4.10.0.0 RC The PR fixes the error in restart network: 2017-04-04 10:27:39,217 DEBUG [c.c.n.r.NetworkHelperImpl] (API-Job-Executor-2:ctx-08904854 job-294

[GitHub] cloudstack pull request #921: CLOUDSTACK-8944 Template download possible fro...

2017-04-04 Thread yvsubhash
Github user yvsubhash closed the pull request at: https://github.com/apache/cloudstack/pull/921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #2008: [CLOUDSTACK-9840] Fix datetime format of snap...

2017-04-03 Thread olivierlemasle
GitHub user olivierlemasle reopened a pull request: https://github.com/apache/cloudstack/pull/2008 [CLOUDSTACK-9840] Fix datetime format of snapshots events Include the timezone in datetime format of snapshot events, to be consistent with every other events. "eventDateTime" was

[GitHub] cloudstack pull request #2008: [CLOUDSTACK-9840] Fix datetime format of snap...

2017-04-03 Thread olivierlemasle
Github user olivierlemasle closed the pull request at: https://github.com/apache/cloudstack/pull/2008 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request #2024: CLOUDSTACK-9857: With this change if agent di...

2017-04-03 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2024 CLOUDSTACK-9857: With this change if agent dies the systemd will catc… …h it properly and show process as exited You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...

2017-04-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/876#discussion_r109299000 --- Diff: plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java --- @@ -359,7 +35

[GitHub] cloudstack pull request #1810: CLOUDSTACK-9647: NIC adapter type becomes e10...

2017-03-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1810#discussion_r109176624 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -280,6 +286,16 @@ public boolean finalizeVirtualMachinePr

[GitHub] cloudstack pull request #1810: CLOUDSTACK-9647: NIC adapter type becomes e10...

2017-03-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1810#discussion_r109176660 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -280,6 +286,16 @@ public boolean finalizeVirtualMachinePr

[GitHub] cloudstack pull request #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with m...

2017-03-31 Thread yvsubhash
Github user yvsubhash commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/914#discussion_r109123538 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -3206,25 +3206,33 @@ public long ge

[GitHub] cloudstack pull request #2021: CLOUDSTACK-9854: Fix test_primary_storage tes...

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/2021 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not ...

2017-03-30 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2022#discussion_r108918688 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java --- @@ -1477,6 +1493,40 @@ public static String resolveHostName

[GitHub] cloudstack pull request #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgra...

2017-03-30 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/2023 BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path for LXC and OVM `mysql> select id,unique_name,name,type,url,updated,created from vm_template where type='SYSTEM'; ++--

  1   2   3   4   5   6   7   8   9   10   >