[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @DaanHoogland @rafaelweingartner Will have a look at the proposed changes and get back to you. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/669 @rafaelweingartner good improvement. @anshul1886 can you merge Rafael's stuff? He addresses the code doublure and the generic exception. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/669 @anshul1886 you asked to show you how it can be done. I opened a PR https://github.com/anshul1886/cloudstack-1/pull/1 for the branch you are using in this PR. Can you take a look?

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @karuturi, We can merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/669 Tested manually. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/669 ### ACS CI BVT Run **Sumarry:** Build Number 382 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder (search

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/669 @anshul1886 Please address the open questions and rebase. Post the latest test results. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @sureshanaparti, Can you have a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:needslove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 Added the missing license on one js file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @jburwell Failed tests are not related to change in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @swill @jburwell Updated in according to newer changes in UI. Also moved consoleKeyboardOptions to js file after jsp change. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/669 @anshul1886 it appears that there was a push to get this PR into 4.9, but @bvbharat found5 test failures and 3 skips. What is the status of resolving these issues? --- If your project is set

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 ### ACS CI BVT Run **Sumarry:** Build Number 134 Hypervisor xenserver NetworkType Advanced Passed=68 Failed=5 Skipped=3 _Link to logs Folder (search b