Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@karuturi this is a simple UI change with screenshots attached, and has
enough LGTM. Please merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@karuturi this is ready for merge, has the screenshots and lgtms
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@rhtyd it seems we can discard 'router' in vpc part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1980
LGTM (based on code only)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Nice @rhtyd LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@DaanHoogland @abhinandanprateek @borisstoyanov @koushik-das @remibergsma
@karuturi let's lgtm and merge this? thanks.
---
If your project is set up for it, you can reply to this email and have y
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@remibergsma thanks, I've found time to fix this now:
![screenshot from 2017-03-26
14-22-41](https://cloud.githubusercontent.com/assets/95203/24329855/c7f61d0e-122f-11e7-9e2f-8974c86dddf9.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@rhtyd Looks great! Shall we do the same for the VPC routers, so that the
overviews look the same?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Is it only showing VR or other appliances providing service in that
network? If it is the latter then the tab name is appropriate otherwise it is
better to name it something like "Virtual Ro
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@PaulAngus @ustcweizhou fixed now, the tab is displayed only to admins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@ustcweizhou @PaulAngus sure, I can add a tab filter to allow only admins
to see this. Right now, whoever can see the network tab(s) can see this tab
too. I'll fix this asap.
---
If your project
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
is there any issue for normal users ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user PaulAngus commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Who (user type) has visibility tab of this tab?
can it be hidden ? many service providers **_may_** not want users to see
this.
---
If your project is set up for it, you can reply to this
14 matches
Mail list logo
