Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@karuturi thanks for fixing it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1944
master is broken after the merge. Pom version changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Thanks @nvazquez @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1944
merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Please ommit my last comment, we were using commons-beanutils version 1.8.3
instead of 1.9.2
LGTM
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//DVIXST/resul
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Hi @rhtyd, thanks for this great improvement! Along with @serg38 we've been
testing in our env and got some failures on `listHostsMetrics` and
`listVolumeMetrics`:
test_list_c
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@karuturi this is merge-able and much needed enhancement to improve UI
performance for large environments
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@karuturi ping? can this be merged as well, this greatly improves the UI
performance for the existing metrics view feature as well as improves the load
time of the infrastructure tab
@abhinand
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Thanks @rashmidixit
@karuturi this is ready for merge, as soon as Travis passes. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@rhtyd I guess this is fine for now. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@rashmidixit the current UI does not support support pluggability of
components within UI like the backend does. We can have a separate tab but not
the implementation that the current metrics view
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@rhtyd On the contrary, I think you adding metrics as pluggable API is a
good idea. However, to seriously make the feature pluggable the UI component
should also load based on a plugin based
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@borisstoyanov can you see the failure in Travis with
test_list_infrastructure_metrics test case?
Thanks @rashmidixit you're right I added this as a plugin to keep it
separate from the core AP
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Thanks @rashmidixit awaiting your review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@rhtyd Will be trying this out today - will post my comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1944
seen it work in practice: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Requesting for review - @abhinandanprateek @DaanHoogland @rashmidixit
@karuturi @koushik-das
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Thanks @borisstoyanov test results LGTM.
/cc @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1944
I've created a Trillian env out of the PR and run the test and it has
passed:
```
test_list_vms_metrics (tests.smoke.test_metrics_api.TestMetrics) ... ===
TestName: test_list_
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Just triggered Trillian env to check the test failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Trillian test result (tid-833)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28094 seconds
Marvin logs:
https://github.com/blueoranguta
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Thanks for testing/reviewing @borisstoyanov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Packaging result: âcentos6 âcentos7 âdebian. JID-492
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1944
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
27 matches
Mail list logo
