Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Folks, what about a middle ground here?
I was checking the commits. For instance, all of the commits
"Added/implemented XXX ." could be all squashed by the same author. There a
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1859
I was one of the RM for 4.6. We never made such a decision nor did we
follow. There were multiple discussions on ML already about squashing vs
merging and we never concluded to do squashing.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1859
At least since August 2015, we've been following the guideline [1][2] for
2LGTMs and to squash changes when they are accepted. AFAIK RMs for 4.6+ have
been asking PR authors to squash their change
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1859
When debugging, I have seen issues with humongous commits with little or no
history. They are very difficult to understand.
This is a feature and it need not be backported. so, backporting t
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Hi @rhtyd,
>From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty
messed-up and it becomes far too difficult to track changes.
I think everything has its ow
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@rajesh-battala I won't accept this PR, sorry to share this but the number
of commits are simply outrageous.
From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty
messe
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Current commits are in the order of some milestones.
As @nitin-maharan told if we squash them into one commit we loose
contributions of induviduals.
On Thu, Mar 16, 20
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@nitin-maharana it becomes easier to triage changes when changes are
confined to a limited number of commits (ideally one per PR), please squash the
commits based on the author (if not to a single
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@rafaelweingartner : As there are multiple contributors to this feature, If
I squash it to one commit, then others are going to lose their part of
contributions. Initially, we thought of
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@nitin-maharana I was looking at the PR.
Do you need to split everything thing there in a different commit?
I think that we still do not have a clear understanding when and how t
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
It has already two LGTMs and contains all successful test results. This is
a big change, as time passes there are more chances of conflicts
appearance(Already resolved once). If anyone wa
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Amazing effort.
From the test results We are good to merge to master.
Thansk
Rajesh Battala
On Wed, Mar 8, 2017 at 12:24 PM, Nitin Kumar Maharana <
notificati.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user sowmyakrishn commented on the issue:
https://github.com/apache/cloudstack/pull/1859
LGTM based on following tests:
Tested with Automated runs for Shared and Dedicated Isolation policies -
test_ncc_integration_dedicated.py and test_ncc_integration_shared.py (also
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Ping @sowmyakrishn @jayapalu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1859
I have accepted the patch you can push it to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1859
### ACS CI BVT Run
**Sumarry:**
Build Number 439
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7
_Link to logs Folder (searc
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@rajesh-battala : Currently running, will post once completes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Please find the test plan executed from below link(Updated in wiki page).
https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan
---
If you
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Thanks.
Once its update please point the same here. So that every one knows it.
Thanks
Rajesh Battala
On Tue, Mar 7, 2017 at 9:27 AM, Nitin Kumar Maharana <
no
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@rajesh-battala : Will update the same in wiki page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Can you please share the test cases and Test plan executed for this feature.
It would be great if community knows the testing done on this feature and
its coverage.
---
If your
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
ping @rajesh-battala @sowmyakrishn
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Sure @rajesh-battala, will look at that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1859
@nitin-maharana @sowmyakrishn Can you please check why CI tests are
failing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Hi @rajesh-battala, I have modified the code. Please review it once and let
me know if any improvement required. Thanks.
---
If your project is set up for it, you can reply to this email
26 matches
Mail list logo
