[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 ok, np closing for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 Hi @resmo, I've made some changes on the Docker file so it might not be possible to merge this PR in the current state. Thanks! --- If your project is set up for it, you can reply t

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1769 @resmo now that PR by @pdion891 is merge, can this be closed? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 ok, I'll update the PR and merge it I think the PR go all required LGTM. I'll confirmed with John, in case he is in a code freeze period. --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 @pdion891 I would say merge #1435 first --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 @resmo could you do a PR on top of #1435 ? or this have to be merged first? so we can get your chances and some of mine. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 So, should we go forward and merge #1435 + #1769 to master? I might just need to rebase and update version number of the current commit. With those 2 PR, we would have master back o

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 I didn't test #1435 yet, but code looks good. The only difference I see is: ~~~ pip install cryptography --force-reinstall ~~~ And I used the mysql connector from MySQL.com but

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1769 Changes look good to me, but waiting for @pdion891 to tell us more :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 Could you look if it conflict with #1435 ? Because I made a pull request to automatically increment version in docker file when changing release of master via ```tools/build/setnextversion.sh`

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1769 LGTM. @pdion891 would you like to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature