[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-03 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rthyd ahh, it didn't occur to me to just pass null. I was trying to initialize that third parameter with a mock (like the other two). Thanks again! --- If your project is set

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 @nathanejohnson I'm not sure what you are doing, the build failure was due to a unit test introduced in this PR. In 4.9+ branches, the unit test did not consider the additional parameter added to

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd I have an issue with circular dependencies trying to make the test work with the new signature. In order to initialize the StoragePoolMonitor, I need a DataStoreManagerImpl type,

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 Thanks for sharing @nathanejohnson in case you've already fixed it, can you send a PR? Otherwise, it's late for me, I'll have a look first in the morning. --- If your project is set up for it, yo

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd It appears that rolling this forward to 4.9 et al has broken builds. The signature of the CreateStoragePool constructor changed between 4.8 and 4.9. https://github.com/ap

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 Merging this based on tests results and review, the failures caused in VPC/VR related tests are known intermittent issues. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-11-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 @murali-reddy @jburwell can we have lgtm/review on this, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-27 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd LGTM on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Trillian test result (tid-167) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32856 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Trillian test result (tid-165) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 29324 seconds Marvin logs: https://github.com/blueoran

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Trillian test result (tid-166) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25743 seconds Marvin logs: https://github.com/blueoranguta

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up for it

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-10-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-29 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Trillian test result (tid-79) Environment: vmware-55u3 (x2), Advanced Networking Total time taken: 30443 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/d

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-29 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 The previous test run was incorrect, several tests were run from master the features that don't exist on 4.8. @blueorangutan test --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-28 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Trillian test result (tid-69) Environment: kvm-centos7 (x2), Advanced Networking Total time taken: 25642 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/d

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd a Trillian-Jenkins test job (centos6 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 @blueorangutan test centos6 kvm-centos7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1694 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe