Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo this PR can be closed as we've moved to a new one with a marvin test
#1663
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Understood, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo this patch does not appear to break things. However, we want to add
a Marvin test case to verify that the fix does not regress again. Does that
make sense?
@rhtyd is planning
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
So, you guys kind of lost me, all I want is my VRs not to be used in DNS
reflection attacks.
Do we have a go or does it break things? :)
---
If your project is set up for it, you can reply to
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Trillian test result (trillian-pr1653-36-vmware-55u3-cs49):
Test completed. 32 look ok, 20 have errors
Test | Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGroup_in
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Trillian test result (trillian-pr1653-34-xenserver-65sp1-cs49):
Test completed. 41 look ok, 11 have errors
Test | Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGrou
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo can you give me push permission on your repository once again to
push the refactoring change, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo np, I'll help with the refactoring fixes etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo understood. I am working to get you some assistance. That work for
you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@jburwell I am afraid I do not have the coding skills to do what you want
re that variable, I am just submitting @ustcweizhou's code from that Jira issue.
Right now basic/sg zones are vuln
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo is it possible to create/update a Marvin test case to verify this
change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 mgmt
+ vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests
against packages at http://packages.sh
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1653
Job ID-94
---
If your project is set up for it, you can reply to this email an
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo thanks, fixed the branch, you may remove my access now :)
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo okay, can you grant me push access on your fork:
https://github.com/NuxRo/cloudstack/tree/patch-4 and I can help fix it for you?
---
If your project is set up for it, you can reply to this
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Rohit unfortunately I do not have git setup properly, I am limited to what
the github interface offers me.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo there are still several commits which have come from master; can you
export the commit (git format-patch -1) and reset --hard origin/4.9 and
re-apply the commit (git am ) and then git push
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Thanks @NuxRo can you rebase against latest 4.9, looks like some more
commits came in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
Rohit, done, go right ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
@NuxRo if you can change the base-branch of the PR to 4.9, I can initiate
some tests on VR/trillian.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user NuxRo commented on the issue:
https://github.com/apache/cloudstack/pull/1653
I've tested this in Adv zone with Security Groups and it works. Can't vouch
for "pure" Adv zones. Perhaps @ustcweizhou can say more.
---
If your project is set up for it, you can reply to this em
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1653
LGTM, we need to also test for users who connect to VPN on that network
(will DNS work for them as well?).
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1653
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
26 matches
Mail list logo
