[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1652 @PaulAngus is their PR superceded by #1688? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1652 @PaulAngus following up on PR feedback. @fmaximus did you apply this patch in another PR? If so, could you please provide a reference? If this patch has not been addressed elsewhere,

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1652 @PaulAngus does this defect occur in 4.9 as well? If so, please re-target the PR to the 4.9 branch. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1652 I will make the change. I also plan to only create the vpc offering if there are Nuage VSP devices configured, which makes more sense for the users of CloudStack that do not use our plugin. -

Re: [GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

@koushik-das Actually there are 3 default VPC offerings. Default VPC offering Redundant VPC offering Nuage VSP VPC Offering The last 2 were introduced in May. VPC offering becomes default if 4th parameter is true in createVpcOffering e.g. createVpcOffering(nuageVPCOfferingName, nuageVPCOfferi

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1652 There should be only one default VPC offering, unless I am missing out something obvious :) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1652 Thanks frank, would you make that change to the Nuage Network offering or shall I? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1652 As Nuage plugin developer, I can't come up with any good reason why it should be default. Also I see that Redundant VPC Offering is set to be a default. Both are most likely just copied

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user PaulAngus commented on the issue: https://github.com/apache/cloudstack/pull/1652 Without full understanding of the Nuage plugin, fixing the test seemed the safest path, one hopes that the nuage offering was configured that way for a good reason. --- If your project is se

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1652 @PaulAngus Shouldn't the product code be fixed instead of the test? If the isDefault property on VPC offerings in not working then that needs to be fixed. I checked the vpc_offerings table i

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1652 LGTM, the Travis test failures are not related to this PR but with tearDown issues fixed here: https://github.com/apache/cloudstack/pull/1648 --- If your project is set up for it, you can reply t