Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Due to changes in marvin, specifically the code generator that runs during
build-time and is not used with either Travis or otherwise, manual tests have
confirmed the functionality working. With e
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd thanks for the expanded commit message. The change makes complete
sense to me now. LGTM for code.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@jburwell fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd that explanation makes sense, and the code seems to address that
issue. Could you please amend the explanation to the commit message?
---
If your project is set up for it, you can repl
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@jburwell the Travis build failed due to tearDown error in one of the tests:
=== TestName: test_listVM_by_id_as_user_vmsfromotherdomain | Status :
EXCEPTION ===
I'll re-kick it. The PR
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@jburwell yes, this PR does not implement API-discovery based generation
but rather fixes the fields that the (api discovery based) codegenerator
should produce in the generated python classes (c
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd Is my understanding correct that auto discovery was implemented in a
previous commit and this PR fixes an defect in that work? If so, could you
please provide a detailed explanation of
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1599
The code seams to make sense. I like the idea of api auto-discovery so
it's a LGTM I guest.
I'm a bit out of context on this one but if it's usefull lets merge it.
Cheers,
---
If
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Pinging for review -- @karuturi @jburwell @koushik-das @swill @pdion891 and
others. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1599
---
If your project is set up for it, you can reply to this email and have your
re
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
r
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
Pinging for review - @wido @koushik-das @karuturi @abhinandanprateek
@jburwell
This enables `cloudstackAPI` api cmd/resp classes generation against a live
running mgmt server.
---
If your p
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
The initiative to split marvin into its own repository has been dropped for
now. Meanwhile, this PR can still be accepted as it fixed the code-generator to
work against the api discovery. I'll sen
14 matches
Mail list logo
