[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread ronatartifact
Github user ronatartifact commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153356376 I considered using a link but was unsure about the policy of references to outside documents. It creates a link that can be easily broke

Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread Ron Wheeler
I can make a JIRA if that will help keep things straight. Ron On 03/11/2015 4:41 AM, DaanHoogland wrote: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225 Ron, your PR looks fine. It is kind of

Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread Ron Wheeler
Thanks I have downloaded and installed Sphinx so I will be able to generate the docs before the next PR. Ron On 03/11/2015 5:49 AM, terbolous wrote: Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153337733 LGTM, formating is fine in the current sphinx theme. Having the link to the feature spec mention at line 305 would have been a nice to have.

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934 LGTM, verified in the github preview that the output renders correctly. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225 Ron, your PR looks fine. It is kind of convention to have a ticket describing what needs to be done and then prepend the ticket id to the PR descript

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-02 Thread ronatartifact
GitHub user ronatartifact opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/31 Clarified GPU description. Added link to design docs for creating new GPU type. You can merge this pull request into a Git repository by running: $ git pull https://github.