Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/5#issuecomment-104673002
@ntavares okay, I'll help review the other one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ntavares commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/5#issuecomment-104670375
@bhaisaab Can you please reject/close this one, it got too messy :-)
---
If your project is set up for it, you can reply to this email and have your
repl
Github user ntavares closed the pull request at:
https://github.com/apache/cloudstack-cloudmonkey/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ntavares commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/5#issuecomment-103955301
Hopefully this is properly rebased now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user ntavares commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/5#issuecomment-103950328
@bhaisaab What a mess ahah... My branch was fresh, I believe I last apache'
commit was from my pull request.. not sure what happened here and it got worse
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/5#issuecomment-103931257
@ntavares looks good to me, though it fails to apply on master. Can you
please rebase against master and send a patch that would apply cleanly? Thanks.
GitHub user ntavares opened a pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/5
signatureversion and backward compatibility
Provide signatureversion as config.option for backward compatibility;
Follow specification: only provide signatureversion=&expires= in U
