Re: [DISCUSS] vlan uri format change

2013-07-29 Thread Wei ZHOU
> > >> -Original Message- > >> From: Prasanna Santhanam [mailto:t...@apache.org] > >> Sent: Saturday, July 27, 2013 11:12 AM > >> To: dev@cloudstack.apache.org > >> Subject: Re: [DISCUSS] vlan uri format change > >> > >> Daan, &

Re: [DISCUSS] vlan uri format change

2013-07-27 Thread Daan Hoogland
separate thread. Daan created a new patch > https://reviews.apache.org/r/12849/ to address backward compat. > >> -Original Message- >> From: Prasanna Santhanam [mailto:t...@apache.org] >> Sent: Saturday, July 27, 2013 11:12 AM >> To: dev@cloudstack.apache.org >

RE: [DISCUSS] vlan uri format change

2013-07-27 Thread Koushik Das
gt; Subject: Re: [DISCUSS] vlan uri format change > > Daan, > > This broke the KVM setups last week on master. I couldn't find your commit- > id for this change scanning the git logs. Toshiaki-san was looking at > CLOUDSTACK-3682 regarding this change [1] where he makes the sche

Re: [DISCUSS] vlan uri format change

2013-07-26 Thread Prasanna Santhanam
Daan, This broke the KVM setups last week on master. I couldn't find your commit-id for this change scanning the git logs. Toshiaki-san was looking at CLOUDSTACK-3682 regarding this change [1] where he makes the scheme backwards compatible to work with KVM agents of the past. Could you please have

Re: [DISCUSS] vlan uri format change

2013-07-01 Thread Daan Hoogland
The gain is that enums like BroadcastDomainType and IsolationType do not have to check for different formats in the presented uri. It also makes it more intiutive what the parts in the uri mean; vlan:// would inmply that id is a hostname instead of a scheme specific identifier. I think I am reduci

Re: [DISCUSS] vlan uri format change

2013-07-01 Thread Hiroaki KAWAI
Daan, I'm curious about what is the improvement of changing the vlan String format in URI? I'm -1 on pushing more complexity in URI, because that's abuse of URI class and sounds it's time to get rid of URI. (2013/07/01 16:47), Daan Hoogland wrote: H, I've been trying to get a patch accepted a

[DISCUSS] vlan uri format change

2013-07-01 Thread Daan Hoogland
H, I've been trying to get a patch accepted and had some discussions to do it in parts as well. I would like to refresh the first part: vlans are now referred as vlan://. I would like to change this to vlan:. This will changee addressing the id as a scheme specific part instead of as a host. As a