Re: [DISCUSS] new findbugs bug findings

2015-06-05 Thread Rajani Karuturi
The jenkins pull request job currently only builds the code (AFAIK) Can we also add enablefindbugs profile to it and see how quickly it analyses? ~Rajani On Fri, Jun 5, 2015 at 12:42 PM, Daan Hoogland wrote: > On Fri, Jun 5, 2015 at 8:42 AM, Rajani Karuturi wrote: > > Hi Daan, > > of the 51 is

Re: [DISCUSS] new findbugs bug findings

2015-06-05 Thread Daan Hoogland
On Fri, Jun 5, 2015 at 8:42 AM, Rajani Karuturi wrote: > Hi Daan, > of the 51 issues, I dont think all of them are new. I checked a few and > they are very old. Some how we never get to a point where we keep up with findbugs this way. The result is we don't use it (enough). > > I think it will b

Re: [DISCUSS] new findbugs bug findings

2015-06-04 Thread Rajani Karuturi
Hi Daan, of the 51 issues, I dont think all of them are new. I checked a few and they are very old. I think it will be useful to run findbugs analysis on every pull request and inform any findings in the new code. Its within the contest and easy to get fixed than looking at them at a later point o

[DISCUSS] new findbugs bug findings

2015-06-04 Thread Daan Hoogland
LS, We have been improving a lot in terms checking submissions and having better (as in less) overall mastaer breakage lately. We are not there yet. At the moment findbugs has 51 new findings and fails the slowbuild for that reason. I think a lot of those can be prevented. For the rest we can att