Hi Daan,
On 13-Aug-2014, at 12:34 pm, Daan Hoogland wrote:
> If this fixes the CLVM issue in KVM environments, I want it in 4.4.
Not related to CLVM directly, just template/url stuff.
>
> Rohit, can you expand on this?
Not a major bugfix, can be even viewed as a feature to support pre-signed
If this fixes the CLVM issue in KVM environments, I want it in 4.4.
Rohit, can you expand on this?
On Tue, Aug 12, 2014 at 11:40 PM, Min Chen wrote:
> Completely remove the checkFormat() will cause trouble for debugging
> issues later if the template format is wrong. I would prefer fail fast
> a
Completely remove the checkFormat() will cause trouble for debugging
issues later if the template format is wrong. I would prefer fail fast
approach instead of spending hours later to deal with wrong file format
issues.
Thanks
-min
On 8/12/14 2:37 PM, "Rohit Yadav" wrote:
>Hey,
>
>On 12-Aug-201
Hey,
On 12-Aug-2014, at 8:53 pm, Min Chen wrote:
> A better fix to address this issue has been committed to master:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=e356465
> 8befaa72cbe5fd510bea2a25b40f108f5. This should address CLOUDSTACK-6940,
> CLOUDSTACK-7312, CLOUDSTAC
A better fix to address this issue has been committed to master:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=e356465
8befaa72cbe5fd510bea2a25b40f108f5. This should address CLOUDSTACK-6940,
CLOUDSTACK-7312, CLOUDSTACK-5512 altogether, same logic to handle
registerTemplate, re
Yes, its important to fail fast and suggest the user that he/she didn't
register the correct format URI.
Also we shouldn’t have boiler plate code for checking the url format for
register iso/template/volume. It should be one util method.
But would you know all the valid formats a URL can be - or wi
Yes. But on second thought, I think that purely removing template url
format checking is too brute force and aggressive, and will cause hard
time in debugging issues thrown by later orchestration flow that relies on
template/volume in specific file format. A better fix to address the issue
raised i
Hi Min,
We need to do this for Upload Volume as well - right ?
Thanks,
-Nitin
On 11/08/14 3:01 PM, "Min Chen" wrote:
>Just checked in a fix to remove similar format check for ISO for
>https://issues.apache.org/jira/browse/CLOUDSTACK-7312.
>
>Thanks
>-min
>
>On 8/11/14 9:59 AM, "Rohit Yadav" w
Just checked in a fix to remove similar format check for ISO for
https://issues.apache.org/jira/browse/CLOUDSTACK-7312.
Thanks
-min
On 8/11/14 9:59 AM, "Rohit Yadav" wrote:
>Thanks for fixing that Min!
>
>I personally did not check the current state of code other than
>discussing it with Marcus
Thanks for fixing that Min!
I personally did not check the current state of code other than discussing it
with Marcus on the issue.
Cheers.
On 11-Aug-2014, at 6:54 pm, Min Chen wrote:
> Yes, I have filed and fixed that bug a month ago.
>
> Thanks
> -min
>
> On 8/10/14 10:39 PM, "Harikrishna P
Yes, I have filed and fixed that bug a month ago.
Thanks
-min
On 8/10/14 10:39 PM, "Harikrishna Patnala"
wrote:
>Hi Rohit,
>
>This was already fixed for templates
>https://issues.apache.org/jira/browse/CLOUDSTACK-6940
>
>We have to do the same for registering ISOs as well.
>
>
>Thanks,
>Harikri
Hi Rohit,
This was already fixed for templates
https://issues.apache.org/jira/browse/CLOUDSTACK-6940
We have to do the same for registering ISOs as well.
Thanks,
Harikrishna
On 08-Aug-2014, at 11:20 pm, Rohit Yadav wrote:
> Hi,
>
> With reference to https://issues.apache.org/jira/browse/CL
Hi,
With reference to https://issues.apache.org/jira/browse/CLOUDSTACK-5512 Marcus
and I think we should remove the template URL format checking logic because:
- It does not handle pre-signed URL (say something that does not end with .vhd
etc, but has bunch of http params)
- One can game the sy
13 matches
Mail list logo
