il 3, 2014 at 9:22 AM
>To: Chiradeep Vittal , Alena Prokharchyk
>,
> Darren Shepherd
>Cc: "dev@cloudstack.apache.org"
>
>Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
>Among Multiple Regions
>
>
>
>
>
>Forgot to mention this, but i
m>, Darren Shepherd <
>> darren.sheph...@citrix.com>
>> Cc: "dev@cloudstack.apache.org"
>>
>> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
>> Among Multiple Regions
>>
>> Forgot to mention this, but it was a gre
d >
> Cc: "dev@cloudstack.apache.org"
>
> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
> Among Multiple Regions
>
> Forgot to mention this, but it was a great help from Darren.
> Thanks again, Darren!
> Alex Ough
>
>
> On Thu, Ap
Ough mailto:alex.o...@sungard.com>>,
"dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>
Cc: Chiradeep Vittal
mailto:chiradeep.vit...@citrix.com>>
Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up Among
>> Alex, I'm attending a conference today, will review the patch
>>> tomorrow.
>>>
>>> -Alena
>>>
>>> From: Alex Ough
>>> Date: Wednesday, March 26, 2014 at 6:35 AM
>>> To: Alena Prokharchyk
>>> Cc: "dev@cloudsta
Date: Wednesday, March 26, 2014 at 7:39 AM
>> To: Alex Ough , "dev@cloudstack.apache.org" <
>> dev@cloudstack.apache.org>
>> Cc: Chiradeep Vittal
>>
>> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
>> Among Multiple Regions
>
n't have.
>
> From: Alena Prokharchyk
> Date: Wednesday, March 26, 2014 at 7:39 AM
> To: Alex Ough , "dev@cloudstack.apache.org" <
> dev@cloudstack.apache.org>
> Cc: Chiradeep Vittal
>
> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync
he.org<mailto:dev@cloudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>
Cc: Chiradeep Vittal
mailto:chiradeep.vit...@citrix.com>>
Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up Among
Multiple Regions
Alex, I’m attending a conference today, will
dnesday, March 26, 2014 at 6:35 AM
> To: Alena Prokharchyk
> Cc: "dev@cloudstack.apache.org" , Chiradeep
> Vittal
>
> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
> Among Multiple Regions
>
> Alena,
>
> It took a little time to u
loudstack.apache.org>"
mailto:dev@cloudstack.apache.org>>, Chiradeep Vittal
mailto:chiradeep.vit...@citrix.com>>
Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up Among
Multiple Regions
Alena,
It took a little time to update the patch because I had a vacati
;1. The reason why I use abstract classes instead of interfaces is
>> >>because
>> >> >there are some basic methods that are used among the inherited
>> >>classes, so
>> >> >I'm not sure why it has to be an interface.
>> >>
; >1. The reason why I use abstract classes instead of interfaces is
>> >>because
>> >> >there are some basic methods that are used among the inherited
>> >>classes, so
>> >> >I'm not sure why it has to be an interface.
>> >> >
&g
t; >- BaseService - UserService, AccountService, DomainService
> >> >- FullSyncProcessor - UserFullSyncProcessor,
> >>AccountFullSyncProcessor,
> >> >DomainFullSyncProcessor
> >> >- RemoteEventProcessor - RemoteUserEventProcessor,
> >
ntProcessor
>> >
>> > => Do you recommend to refactor them into defining interfaces and
>> >creating one class implementing all methods related with each user,
>> >account
>> >and domain?
>> >
>> >3. Let me work on changing names.
>
rokharc...@citrix.com> wrote:
> >
> >> Alex, see inline.
> >>
> >> -Alena.
> >>
> >> From: Alex Ough
> >> Date: Thursday, March 13, 2014 at 1:00 PM
> >> To: Alena Prokharchyk
> >> Cc: "dev@cloud
ch 13, 2014 at 1:00 PM
>> To: Alena Prokharchyk
>> Cc: "dev@cloudstack.apache.org" , Chiradeep
>> Vittal
>>
>> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
>> Among Multiple Regions
>>
>> Hi Alena,
>>
&g
ittal
>
> Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up
> Among Multiple Regions
>
> Hi Alena,
>
> Patch B,
> I'm not quite familiar with java, so I have a little difficulty in
> following your recommendation.
> Can you send me an example u
ache.org>>, Chiradeep Vittal
mailto:chirade...@gmail.com>>
Subject: Re: [DISCUSS]{BEHAVIORAL-CHANGE]Domain-Account-User Sync Up Among
Multiple Regions
Hi Alena,
Patch B,
I'm not quite familiar with java, so I have a little difficulty in following
your recommendation.
Can you se
Hi Alena,
Patch B,
I'm not quite familiar with java, so I have a little difficulty in
following your recommendation.
Can you send me an example using 'BaseInterface' and/or 'AccountInterface'?
It will be very helpful and appreciated.
Patch A,
To reduce the number of requests to the remote regions
Alex, I have some comments.
Patch B.
* You shouldn’t make your service a part of cloud-mom-rabbitmq plugin.
Your subscribers/implementation are specific to your feature, and you need
to introduce a special plugin just for your service.
* AccountInterface and BaseInterface are still regular classe
Chiradeep,
Any comments on them?
Thanks
Alex Ough
On Wed, Mar 12, 2014 at 10:58 AM, Alex Ough wrote:
> And I also uploaded the patch B that includes new implementation to
> support multi regions.
>
> Thanks
> Alex Ough
>
>
> On Wed, Mar 12, 2014 at 10:17 AM, Alex Ough wrote:
>
>> I uploaded
And I also uploaded the patch B that includes new implementation to support
multi regions.
Thanks
Alex Ough
On Wed, Mar 12, 2014 at 10:17 AM, Alex Ough wrote:
> I uploaded the patch A that includes only core changes, so please review
> it and let me know if you have any comments.
>
> Thanks
>
I uploaded the patch A that includes only core changes, so please review it
and let me know if you have any comments.
Thanks
Alex Ough
On Wed, Mar 12, 2014 at 8:24 AM, Alex Ough wrote:
> Hi Chiradeep,
>
> Can you give me the example of the Singleton service class you mentioned?
> I'm not sure
Hi Chiradeep,
Can you give me the example of the Singleton service class you mentioned?
I'm not sure if you are asking the name changes or else because those
classes are abstract classes and do not need to be singleton class.
And let me try the refactoring and ask confirmations to you, so I hope
H Alex, I considder Chiradeeps comments quite valid and serious enough
to anticipate not making friday 14:00 CET. That would mean no merge
before 4.4. Can you live with that?
On Wed, Mar 12, 2014 at 6:40 AM, Chiradeep Vittal
wrote:
> Hi Alex,
>
> If you look at the general design of CloudStack, t
Hi Alex,
If you look at the general design of CloudStack, there are Singleton
service interfaces which are then implemented with real classes. This
facilitates easy testing by mocking the interface. In your new files
(BaseInterface, which by the way is NOT an interface, AccountService,
which is NO
Hi Daan,
I didn't update the patch after the couple of works because I wanted to do
it with others Chiradeep asked if any.
Let me know when you want me to.
Thanks
Alex Ough
On Tue, Mar 11, 2014 at 4:37 PM, Daan Hoogland wrote:
> I will call the merge in a moment, but won't do it immediately.
>
I will call the merge in a moment, but won't do it immediately.
Be there for me when any issues come up. If not I will revert it.
@Chiradeep: did Alex answer your concerns adequately?
kind regards,
On Tue, Mar 11, 2014 at 6:43 PM, Alex Ough wrote:
> I worked on a couple of items, so can you g
I worked on a couple of items, so can you give me the confirmation for the
rest items so that I can wrap this up?
I really want to include this into 4.4.
Thanks
Alex Ough
On Mon, Mar 10, 2014 at 3:41 PM, Alex Ough wrote:
> Please see my reply/question in blue.
>
> Thanks
> Alex Ough
>
>
> On M
Please see my reply/question in blue.
Thanks
Alex Ough
On Mon, Mar 10, 2014 at 1:25 PM, Chiradeep Vittal <
chiradeep.vit...@citrix.com> wrote:
> I haven¹t looked at it because it is huge. But preliminary scan:
>
> - there are unit tests missing for changes to core CS code
>
Unit tests
I haven¹t looked at it because it is huge. But preliminary scan:
- there are unit tests missing for changes to core CS code
- uses com.amazonaws.util.json (why?)
- code format does not follow coding convention ( placement of {}, camel
case api_interface )
- package namespace is com.cloud instead o
Hi everyody,
The people at sungard have been making this change for 4.4 and I want
to merge/apply it this week. It is more then a screenfull and might
cause issue is a setup or two.
have a look at https://reviews.apache.org/r/17790/
a ref to ticket and fs page are in the review request.
kind re
32 matches
Mail list logo