Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
s/sytem/system VM/ On Thu, 7 May 2015 17:38 Daan Hoogland wrote: > No, we want to configure the system version instead of the hard coded > one. I fixed it in master but didn't back port. > > On Thu, 7 May 2015 17:35 Rohit Yadav wrote: > >> Hi Daan, >> >> > On 07-May-2015, at 5:21 pm, Daan Hoog

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
No, we want to configure the system version instead of the hard coded one. I fixed it in master but didn't back port. On Thu, 7 May 2015 17:35 Rohit Yadav wrote: > Hi Daan, > > > On 07-May-2015, at 5:21 pm, Daan Hoogland > wrote: > > > > I spoke with Remi, we want a fix in 4.4 and 4.5 so 4.4.4

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Rohit Yadav
> On 07-May-2015, at 5:11 pm, Sebastien Goasguen wrote: > > went so fast I did not have time to vote. You’re a busy man :) We were able to gather consensus in last 72+ hours with no -1s or blockers, so at the end of the window I moved ahead with the release but please do test and share your r

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Rohit Yadav
Hi Daan, > On 07-May-2015, at 5:21 pm, Daan Hoogland wrote: > > I spoke with Remi, we want a fix in 4.4 and 4.5 so 4.4.4 and 4.5.2 :) What’s the issue you found? Is it a blocker/critical? Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bh

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
I spoke with Remi, we want a fix in 4.4 and 4.5 so 4.4.4 and 4.5.2 :) Op do 7 mei 2015 om 17:14 schreef Sebastien Goasguen : > > > On May 7, 2015, at 2:45 PM, Rohit Yadav > wrote: > > > > The current 4.5.1 candidate has no -1s and enough votes to pass, I was > waiting for others who have not vot

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Sebastien Goasguen
> On May 7, 2015, at 2:45 PM, Rohit Yadav wrote: > > The current 4.5.1 candidate has no -1s and enough votes to pass, I was > waiting for others who have not votes to share their results but since, the > voting window is over I’ll tally and share results in next two hours. > went so fast I d

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
all, I justdid and pushed the merge. I suppose due to the release and removal of awsapi it had some conflicts this time around. be aware that we now need to be disciplined at stabalizing master and no longer commit directly. Let's find at least 6 release managers and agree that only merges that t

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Rohit Yadav
The current 4.5.1 candidate has no -1s and enough votes to pass, I was waiting for others who have not votes to share their results but since, the voting window is over I’ll tally and share results in next two hours. Regards. > On 07-May-2015, at 1:57 pm, Daan Hoogland wrote: > > ok, we agree

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
ok, we agree I was going to wait on Rohit's ping and then re-merge and push Op do 7 mei 2015 om 12:42 schreef Abhinandan Prateek < abhinandan.prat...@shapeblue.com>: > Daan, > > I was thinking voting will be concluded today ( looks like I confused it > with GA). > Anyhow it can be done now, in

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Abhinandan Prateek
Daan, I was thinking voting will be concluded today ( looks like I confused it with GA). Anyhow it can be done now, in case there are issues they can be merged as and when there are relevant commits. > On 07-May-2015, at 3:50 pm, Daan Hoogland wrote: > > why not before Abhi? as we have an R

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
why not before Abhi? as we have an RC we could merge now. Op do 7 mei 2015 om 11:59 schreef Abhinandan Prateek < abhinandan.prat...@shapeblue.com>: > +1 > > Lets merge as soon as we have 4.5 GA. > > > On 07-May-2015, at 2:47 pm, Daan Hoogland > wrote: > > > > LS, > > > > announce part: As we ha

Re: [ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Abhinandan Prateek
+1 Lets merge as soon as we have 4.5 GA. > On 07-May-2015, at 2:47 pm, Daan Hoogland wrote: > > LS, > > announce part: As we have an rc that did not get any -1 yet I want to merge > 4.5 in master now. It will result in 389 commits being merged without > conflicts detectable by git. That is not a

[ANNOUNCE][PROPOSAL] merge of 4.5 code in master

2015-05-07 Thread Daan Hoogland
LS, announce part: As we have an rc that did not get any -1 yet I want to merge 4.5 in master now. It will result in 389 commits being merged without conflicts detectable by git. That is not an fool proof guarantee of a working system of course, hence this heads up. proposal part: I would like to