Re: [ACS41][Patch Request]CLOUDSTACK-2656

2013-05-24 Thread Min Chen
Thanks. -min On 5/24/13 8:26 AM, "Chip Childers" wrote: >On Thu, May 23, 2013 at 10:21:44PM +, Min Chen wrote: >> Hi Chip, >> Can you please cherry-pick the following commit from master to 4.1? >> This is to address empty UUID columns for pre-4.1 schema entities. We >> missed two "snap

Re: [ACS41][Patch Request]

2013-05-24 Thread Chip Childers
On Thu, May 23, 2013 at 05:35:11PM +, Murali Reddy wrote: > Chip, please cherry-pick to 4.1 > > CLOUDSTACK-2587: netscaler_pod_ref DB upgrade is missing from 3.0.2 to 4.x > > added missing schema as part of 4.0 to 4.1 upgrade > > Branch: refs/heads/master > Commit: 623a26e469ca7354a7dbe6b895

Re: [ACS41][Patch Request]CLOUDSTACK-2656

2013-05-24 Thread Chip Childers
On Thu, May 23, 2013 at 10:21:44PM +, Min Chen wrote: > Hi Chip, > Can you please cherry-pick the following commit from master to 4.1? > This is to address empty UUID columns for pre-4.1 schema entities. We > missed two "snapshot_policy" and "dc_storage_network_ip_range". > > commit a46b

[ACS41][Patch Request]CLOUDSTACK-2656

2013-05-23 Thread Min Chen
Hi Chip, Can you please cherry-pick the following commit from master to 4.1? This is to address empty UUID columns for pre-4.1 schema entities. We missed two "snapshot_policy" and "dc_storage_network_ip_range". commit a46b4d8273e9033e55172bf2d00845820bc9511a Author: Min Chen Date: Thu M

[ACS41][Patch Request]

2013-05-23 Thread Murali Reddy
Chip, please cherry-pick to 4.1 CLOUDSTACK-2587: netscaler_pod_ref DB upgrade is missing from 3.0.2 to 4.x added missing schema as part of 4.0 to 4.1 upgrade Branch: refs/heads/master Commit: 623a26e469ca7354a7dbe6b8954276985e289687 Parents: cc49230 Author: Murali Reddy mailto:muralimmre...@gmai

Re: [ACS41][Patch Request]

2013-05-23 Thread Chip Childers
On Wed, May 22, 2013 at 11:15:15PM -0600, Marcus Sorensen wrote: > commit 795fd803da3eadee0fae1a13d0e97ae57b239657 > Author: Marcus Sorensen > Date: Wed May 22 23:12:30 2013 -0600 > > Summary: KVM - double migration can fail > > Detail: Undefine VM after migration. Lingering domain def

Re: [ACS41][Patch Request]

2013-05-22 Thread Prasanna Santhanam
Sorry - I saw that as 2460. On Wed, May 22, 2013 at 11:15:15PM -0600, Marcus Sorensen wrote: > commit 795fd803da3eadee0fae1a13d0e97ae57b239657 > Author: Marcus Sorensen > Date: Wed May 22 23:12:30 2013 -0600 > > Summary: KVM - double migration can fail > > Detail: Undefine VM after mi

Re: [ACS41][Patch Request]

2013-05-22 Thread Prasanna Santhanam
Should that be CLOUDSTACK-2330? On Wed, May 22, 2013 at 11:15:15PM -0600, Marcus Sorensen wrote: > commit 795fd803da3eadee0fae1a13d0e97ae57b239657 > Author: Marcus Sorensen > Date: Wed May 22 23:12:30 2013 -0600 > > Summary: KVM - double migration can fail > > Detail: Undefine VM afte

[ACS41][Patch Request]

2013-05-22 Thread Marcus Sorensen
commit 795fd803da3eadee0fae1a13d0e97ae57b239657 Author: Marcus Sorensen Date: Wed May 22 23:12:30 2013 -0600 Summary: KVM - double migration can fail Detail: Undefine VM after migration. Lingering domain definitions cause migrations back to the original host to fail, since domain a

Re: [ACS41][Patch Request]

2013-05-15 Thread Chip Childers
On Wed, May 15, 2013 at 10:49:11AM -0600, Marcus Sorensen wrote: > bfc5887a1bf6b41e88dd7a8f9987fcee8d3d9175 > > use kvmclock for system vms > Done

[ACS41][Patch Request]

2013-05-15 Thread Marcus Sorensen
bfc5887a1bf6b41e88dd7a8f9987fcee8d3d9175 use kvmclock for system vms

Re: [ACS41][Patch Request]

2013-05-02 Thread Chip Childers
On Wed, May 01, 2013 at 02:20:38PM -0600, Marcus Sorensen wrote: > commit 71a17e4c139a5c4e4be326e15548e0d6036dfd9a > Author: Marcus Sorensen > Date: Wed May 1 14:10:56 2013 -0600 > > CLOUDSTACK-2110 : allow vm to have multiple dhcp entries on same router > > Signed-off-by: Marcus Soren

[ACS41][Patch Request]

2013-05-01 Thread Marcus Sorensen
commit 71a17e4c139a5c4e4be326e15548e0d6036dfd9a Author: Marcus Sorensen Date: Wed May 1 14:10:56 2013 -0600 CLOUDSTACK-2110 : allow vm to have multiple dhcp entries on same router Signed-off-by: Marcus Sorensen 1367439056 -0600

Re: [ACS41][Patch Request]

2013-04-29 Thread Chip Childers
On Mon, Apr 29, 2013 at 10:02:43AM -0600, Marcus Sorensen wrote: > commit a0dbf8909058dba202c057f5b9d589026399c6ef > Author: Marcus Sorensen > Date: Mon Apr 29 10:01:44 2013 -0600 > > Look for null pointer on account id before trying to update usage when > releasing > an IP. This seems

[ACS41][Patch Request]

2013-04-29 Thread Marcus Sorensen
commit a0dbf8909058dba202c057f5b9d589026399c6ef Author: Marcus Sorensen Date: Mon Apr 29 10:01:44 2013 -0600 Look for null pointer on account id before trying to update usage when releasing an IP. This seems to be possible if expunge fails at some point after freeing an IP, on subse

Re: [ACS41][Patch Request]

2013-04-26 Thread Chip Childers
On Thu, Apr 25, 2013 at 10:51:48PM -0600, Marcus Sorensen wrote: > CLOUDSTACK-2195 > > https://reviews.apache.org/r/10791/ Ack - applied to 4.1

[ACS41][Patch Request]

2013-04-25 Thread Marcus Sorensen
CLOUDSTACK-2195 https://reviews.apache.org/r/10791/

Re: [ACS41]Patch Request

2013-04-25 Thread Min Chen
Thanks. Applied to master. -min On 4/25/13 4:59 PM, "Chip Childers" wrote: >On Thu, Apr 25, 2013 at 04:24:06PM -0700, Min Chen wrote: >> Hi Chip, >> >> https://reviews.apache.org/r/10789 is the patch for CLOUDSTACK-2196 >>and CLOUDSTACK-2126: fix missing async job status in listXXX api and >>

Re: [ACS41]Patch Request

2013-04-25 Thread Chip Childers
On Thu, Apr 25, 2013 at 04:24:06PM -0700, Min Chen wrote: > Hi Chip, > > https://reviews.apache.org/r/10789 is the patch for CLOUDSTACK-2196 and > CLOUDSTACK-2126: fix missing async job status in listXXX api and incorrect > async job status in other async api. Can you please commit it to 4.1? >

[ACS41]Patch Request

2013-04-25 Thread Min Chen
Hi Chip, https://reviews.apache.org/r/10789 is the patch for CLOUDSTACK-2196 and CLOUDSTACK-2126: fix missing async job status in listXXX api and incorrect async job status in other async api. Can you please commit it to 4.1? Thanks -min

Re: [ACS41][Patch Request]

2013-04-25 Thread Chip Childers
On Thu, Apr 25, 2013 at 07:33:43AM -0600, Marcus Sorensen wrote: > Sorry, I should have mentioned in my first response that I had just removed > the attachment from the review request. That would have clarified things. > Done! > > On Thu, Apr 25, 2013 at 7:32 AM, Marcus Sorensen wrote: > > > y

Re: [ACS41][Patch Request]

2013-04-25 Thread Marcus Sorensen
Sorry, I should have mentioned in my first response that I had just removed the attachment from the review request. That would have clarified things. On Thu, Apr 25, 2013 at 7:32 AM, Marcus Sorensen wrote: > yes > > > On Thu, Apr 25, 2013 at 7:31 AM, Chip Childers > wrote: > >> On Thu, Apr 25,

Re: [ACS41][Patch Request]

2013-04-25 Thread Marcus Sorensen
yes On Thu, Apr 25, 2013 at 7:31 AM, Chip Childers wrote: > On Thu, Apr 25, 2013 at 07:29:55AM -0600, Marcus Sorensen wrote: > > Sorry, I attached the patch rather than updating the review diff because > it > > was just a quick idea and I wanted to get some feedback on it. After > > working a bi

Re: [ACS41][Patch Request]

2013-04-25 Thread Chip Childers
On Thu, Apr 25, 2013 at 07:29:55AM -0600, Marcus Sorensen wrote: > Sorry, I attached the patch rather than updating the review diff because it > was just a quick idea and I wanted to get some feedback on it. After > working a bit more, I came up with a better solution based on that idea and > updat

Re: [ACS41][Patch Request]

2013-04-25 Thread Marcus Sorensen
Sorry, I attached the patch rather than updating the review diff because it was just a quick idea and I wanted to get some feedback on it. After working a bit more, I came up with a better solution based on that idea and updated the diff with it. On Thu, Apr 25, 2013 at 7:25 AM, Chip Childers wro

Re: [ACS41][Patch Request]

2013-04-25 Thread Chip Childers
On Wed, Apr 24, 2013 at 03:24:20PM -0600, Marcus Sorensen wrote: > https://reviews.apache.org/r/10766/ I'm unclear about the current state of this review request. There is the actual patch for the review [1] and an attached patch [2]. Which should be applied? -chip [1] https://reviews.apache.o

[ACS41][Patch Request]

2013-04-24 Thread Marcus Sorensen
https://reviews.apache.org/r/10766/

Re: [ACS41][Patch Request]

2013-04-23 Thread Chip Childers
On Tue, Apr 23, 2013 at 10:42:53AM +, Sanjay Tripathi wrote: > CLOUDSTACK-2147 : Missing configuration variable max.project.cpus in > configuration table. > > --Sanjay Applied. Thanks!

[ACS41][Patch Request]

2013-04-23 Thread Sanjay Tripathi
CLOUDSTACK-2147 : Missing configuration variable max.project.cpus in configuration table. --Sanjay From: Sanjay Tripathi [mailto:nore...@reviews.apache.org] On Behalf Of Sanjay Tripathi Sent: Tuesday, April 23, 2013 3:56 PM To: Min Chen; Chip Childers; Devdeep Singh Cc: cloudstack; Sanjay Tripa

Re: [ACS41][Patch Request]

2013-04-22 Thread Chip Childers
On Mon, Apr 22, 2013 at 04:53:35PM -0600, Marcus Sorensen wrote: > https://reviews.apache.org/r/10714/ > > RPMs don't build via package.sh when '-SNAPSHOT' is removed from version OK - Cancelling the vote then.

[ACS41][Patch Request]

2013-04-22 Thread Marcus Sorensen
https://reviews.apache.org/r/10714/ RPMs don't build via package.sh when '-SNAPSHOT' is removed from version

Re: [ACS41][Patch Request]

2013-04-17 Thread Chip Childers
On Wed, Apr 17, 2013 at 01:13:36PM -0600, Marcus Sorensen wrote: > commit 8d0bea994dcd74cd6707b58ac2e4060a93f52d96 > Author: Marcus Sorensen > Date: Wed Apr 17 13:10:29 2013 -0600 > > CLOUDSTACK-2071 - VirtualMachineManagerImpl.java start() method for > instance > can fail to start a VM

Re: [ACS41][Patch Request][CLOUDSTACK-2067]

2013-04-17 Thread Chip Childers
On Wed, Apr 17, 2013 at 01:00:50PM -0600, Marcus Sorensen wrote: > See review request, this patch only partially applies to master, but needed > rework to do so. > > https://reviews.apache.org/r/10591/ Applied. Thanks!

[ACS41][Patch Request]

2013-04-17 Thread Marcus Sorensen
commit 8d0bea994dcd74cd6707b58ac2e4060a93f52d96 Author: Marcus Sorensen Date: Wed Apr 17 13:10:29 2013 -0600 CLOUDSTACK-2071 - VirtualMachineManagerImpl.java start() method for instance can fail to start a VM without notifying caller, if no exception is triggered. The result is that

[ACS41][Patch Request][CLOUDSTACK-2067]

2013-04-17 Thread Marcus Sorensen
See review request, this patch only partially applies to master, but needed rework to do so. https://reviews.apache.org/r/10591/

Re: [ACS41][Patch Request]

2013-04-17 Thread Chip Childers
On Wed, Apr 17, 2013 at 11:55:16PM +0800, Mice Xia wrote: > There's another one in reviewboard: > > https://reviews.apache.org/r/10536/ > Summary: > CLOUDSTACK-1894 User is not able to deploy VMs in a project[permission > denied to access the guest network) Done

Re: [ACS41][Patch Request]

2013-04-17 Thread Chip Childers
On Tue, Apr 16, 2013 at 10:27:17PM -0600, Marcus Sorensen wrote: > Thanks, here's one more related to it... > > commit 2057221f4f1fd5afde422b367fc416d4e44275cb > Author: Marcus Sorensen > Date: Tue Apr 16 22:18:38 2013 -0600 > > CLOUDSTACK-2051 - The previous patch ensures that holes in d

Re: [ACS41][Patch Request]

2013-04-17 Thread Mice Xia
There's another one in reviewboard: https://reviews.apache.org/r/10536/ Summary: CLOUDSTACK-1894 User is not able to deploy VMs in a project[permission denied to access the guest network) 2013/4/17 Chip Childers > On Wed, Apr 17, 2013 at 09:36:20PM +0800, Mice Xia wrote: > > commit 4d0a460bad

Re: [ACS41][Patch Request]

2013-04-17 Thread Chip Childers
On Wed, Apr 17, 2013 at 09:36:20PM +0800, Mice Xia wrote: > commit 4d0a460bad05bfc89a9f2d93724221c7c517626e > Author: Mice Xia > Date: Wed Apr 17 21:24:33 2013 +0800 > > fix CLOUDSTACK 1991 CreateTagsCmd.java, DeleteTagsCmd.java, and > ListTagsCmd.java all contain invalid version > > -

[ACS41][Patch Request]

2013-04-17 Thread Mice Xia
commit 4d0a460bad05bfc89a9f2d93724221c7c517626e Author: Mice Xia Date: Wed Apr 17 21:24:33 2013 +0800 fix CLOUDSTACK 1991 CreateTagsCmd.java, DeleteTagsCmd.java, and ListTagsCmd.java all contain invalid version --- https://re

Re: [ACS41][Patch Request]

2013-04-16 Thread Marcus Sorensen
Thanks, here's one more related to it... commit 2057221f4f1fd5afde422b367fc416d4e44275cb Author: Marcus Sorensen Date: Tue Apr 16 22:18:38 2013 -0600 CLOUDSTACK-2051 - The previous patch ensures that holes in deleting storage pools the proper way won't cause problems for KVM HA Monito

Re: [ACS41][Patch Request]

2013-04-16 Thread Chip Childers
On Tue, Apr 16, 2013 at 12:07:52PM -0600, Marcus Sorensen wrote: > commit 202930fd554ddc9a8e78cf39ae54a4e3a56d3904 > Author: Marcus Sorensen > Date: Tue Apr 16 12:07:15 2013 -0600 > > CLOUDSTACK-2051 Allow KVM HA Monitor to verify that a NfsStoragePool is > valid before running the scr

[ACS41][Patch Request]

2013-04-16 Thread Marcus Sorensen
commit 202930fd554ddc9a8e78cf39ae54a4e3a56d3904 Author: Marcus Sorensen Date: Tue Apr 16 12:07:15 2013 -0600 CLOUDSTACK-2051 Allow KVM HA Monitor to verify that a NfsStoragePool is valid before running the script that mounts it and touches the HA files. Signed-off-by: Marcus Soren

Re: [ACS41][Patch Request] NiciraNvp implements IpDeployer

2013-04-15 Thread Chip Childers
On Mon, Apr 15, 2013 at 01:45:51PM +, Hugo Trippaers wrote: > Please cherry pick 1f0b804dd3972f373c196799fc48929a7bc3f473 to 4.1 > > Fixes a bug where ips would not apply to a Nicira L3 gateway. > > > Cheers, > > Hugo Done: commit dbaeda0c211a842fb3a72b5d1f433de7737a47b2 Author: Hugo Trip

[ACS41][Patch Request] NiciraNvp implements IpDeployer

2013-04-15 Thread Hugo Trippaers
Please cherry pick 1f0b804dd3972f373c196799fc48929a7bc3f473 to 4.1 Fixes a bug where ips would not apply to a Nicira L3 gateway. Cheers, Hugo > -Original Message- > From: h...@apache.org [mailto:h...@apache.org] > Sent: Monday, April 15, 2013 3:43 PM > To: comm...@cloudstack.apache.org

Re: [ACS41][Patch Request] CLOUDSTACK-1934: NPE with listSupportedNetworkServices

2013-04-12 Thread Chip Childers
On Fri, Apr 12, 2013 at 11:21:10AM +, Murali Reddy wrote: > > Please cherry-pick to 4.1 > > CLOUDSTACK-1934: NPE with listSupportedNetworkServices > > For 'connectivity' network service current set of providers (MidoNet, > NiciraNcp) not necessarily part of OSS builds. So handle the case whe

[ACS41][Patch Request] CLOUDSTACK-1934: NPE with listSupportedNetworkServices

2013-04-12 Thread Murali Reddy
Please cherry-pick to 4.1 CLOUDSTACK-1934: NPE with listSupportedNetworkServices For 'connectivity' network service current set of providers (MidoNet, NiciraNcp) not necessarily part of OSS builds. So handle the case where there are no providers for a service Branch: refs/heads/master Commit: c

Re: [ACS41][Patch Request]

2013-04-11 Thread Marcus Sorensen
Ok. I also noticed that for me gmail picked up the subjects of [ACS40][Patch Request] and [ACS41][Patch Request] and stuffed them in the same thread for some reason, even though they were sent as two distinct messages. On Thu, Apr 11, 2013 at 11:40 AM, Chip Childers wrote: > On Wed, Apr

Re: [ACS41][Patch Request]

2013-04-11 Thread Chip Childers
On Wed, Apr 10, 2013 at 11:11:21PM +, Likitha Shetty wrote: > Branch: refs/heads/master > Commit: a0b5ebccb814cbb12c5f40aa0c8894ebb3b322d6 > Author: Likitha Shetty > Date: Thu Apr 11 04:25:31 2013 +0530 > > CLOUDSTACK-1988. Attempting to register a AWS API user fails with error code >

Re: [ACS41][Patch Request]

2013-04-11 Thread Chip Childers
On Wed, Apr 10, 2013 at 12:39:24PM -0600, Marcus Sorensen wrote: > commit be55c5b3a58376eb2048a8add155ff09f14e65eb > Author: Marcus Sorensen > Date: Tue Apr 9 16:26:08 2013 -0600 > > VPC - new system vm doesn't bring up eth0 reliably, and we don't set > eth0 to > auto start like we shou

Re: [ACS41][Patch Request]

2013-04-11 Thread Chip Childers
On Wed, Apr 10, 2013 at 12:28:57PM -0600, Marcus Sorensen wrote: > This is a follow-up to previous patch request for CLOUDSTACK-1565 that we > though should go into 4.1 > > commit 9670553ea85d6593046425f2c040cc08d2e61733 > Author: Marcus Sorensen > Date: Wed Apr 10 12:17:31 2013 -0600 > >

Re: [ACS41][Patch Request]

2013-04-11 Thread Chip Childers
On Wed, Apr 10, 2013 at 12:28:57PM -0600, Marcus Sorensen wrote: > This is a follow-up to previous patch request for CLOUDSTACK-1565 that we > though should go into 4.1 > > commit 9670553ea85d6593046425f2c040cc08d2e61733 > Author: Marcus Sorensen > Date: Wed Apr 10 12:17:31 2013 -0600 > >

Re: [ACS41][Patch Request]

2013-04-11 Thread Chip Childers
On Thu, Apr 11, 2013 at 09:55:38AM -0600, Marcus Sorensen wrote: > commit ca8ac08cf37cd9ea8a50d323ac596da16319e7ab > Author: Marcus Sorensen > Date: Thu Apr 11 09:50:48 2013 -0600 > > CLOUDSTACK-2003: When accounts and domains are deleted, cleanup can > fail, > leaving instances in eter

[ACS41][Patch Request]

2013-04-11 Thread Marcus Sorensen
commit ca8ac08cf37cd9ea8a50d323ac596da16319e7ab Author: Marcus Sorensen Date: Thu Apr 11 09:50:48 2013 -0600 CLOUDSTACK-2003: When accounts and domains are deleted, cleanup can fail, leaving instances in eternal expunged state. This happens when a domain is deleted while a deleted a

[ACS41][Patch Request]

2013-04-10 Thread Likitha Shetty
Branch: refs/heads/master Commit: a0b5ebccb814cbb12c5f40aa0c8894ebb3b322d6 Author: Likitha Shetty Date: Thu Apr 11 04:25:31 2013 +0530 CLOUDSTACK-1988. Attempting to register a AWS API user fails with error code 401. Fix the code to refer to /usr/share/cloudstack-management/webapps7080/aw

Re: [ACS41][Patch Request]

2013-04-10 Thread Chip Childers
On Wed, Apr 10, 2013 at 12:28:57PM -0600, Marcus Sorensen wrote: > This is a follow-up to previous patch request for CLOUDSTACK-1565 that we > though should go into 4.1 > > commit 9670553ea85d6593046425f2c040cc08d2e61733 > Author: Marcus Sorensen > Date: Wed Apr 10 12:17:31 2013 -0600 > >

[ACS41][Patch Request]

2013-04-10 Thread Marcus Sorensen
commit be55c5b3a58376eb2048a8add155ff09f14e65eb Author: Marcus Sorensen Date: Tue Apr 9 16:26:08 2013 -0600 VPC - new system vm doesn't bring up eth0 reliably, and we don't set eth0 to auto start like we should. cloud-early-config sets 'auto lo $1', but we don't pass $1 in vpc rout

[ACS41][Patch Request]

2013-04-10 Thread Marcus Sorensen
This is a follow-up to previous patch request for CLOUDSTACK-1565 that we though should go into 4.1 commit 9670553ea85d6593046425f2c040cc08d2e61733 Author: Marcus Sorensen Date: Wed Apr 10 12:17:31 2013 -0600 In system vm, wait for interface to be available before configuring gateway.

Re: [ACS41][Patch request] CLOUDSTACK-694 Please pull 6c9fcb8c8f6739c9bad93fea8c28be3a768ca694 into 4.1

2013-04-10 Thread Chip Childers
On Apr 10, 2013, at 2:11 AM, Hugo Trippaers wrote: > Please cherry-pick this commit into 4.1 > > Related to CLOUDSTACK-694 > > > Cheers, > > Hugo > Ack and done

[ACS41][Patch request] CLOUDSTACK-694 Please pull 6c9fcb8c8f6739c9bad93fea8c28be3a768ca694 into 4.1

2013-04-09 Thread Hugo Trippaers
Please cherry-pick this commit into 4.1 Related to CLOUDSTACK-694 Cheers, Hugo

Re: [ACS41][Patch Request] CLOUDSTACK-1834: Events are not generated for registerUserKeys()

2013-04-09 Thread Chip Childers
On Tue, Apr 09, 2013 at 12:19:29PM +, Murali Reddy wrote: > CLOUDSTACK-1834: Events are not generated for registerUserKeys() > > Branch: refs/heads/master > Commit: 9180bd599015ce248e894a0ef476a4604b1533e4 > Parents: 47dc989 > Author: Murali Reddy mailto:murali.re...@citrix.com>> > Authored: T

[ACS41][Patch Request] CLOUDSTACK-1834: Events are not generated for registerUserKeys()

2013-04-09 Thread Murali Reddy
CLOUDSTACK-1834: Events are not generated for registerUserKeys() Branch: refs/heads/master Commit: 9180bd599015ce248e894a0ef476a4604b1533e4 Parents: 47dc989 Author: Murali Reddy mailto:murali.re...@citrix.com>> Authored: Tue Apr 9 17:45:19 2013 +0530 Committer: Murali Reddy mailto:murali.re...@ci

Re: [ACS41][Patch request] f1259d50bdd6120174717f4cce6a45dc12b6645b

2013-04-04 Thread Chip Childers
On Thu, Apr 04, 2013 at 03:06:21PM +, Hugo Trippaers wrote: > Hey Chip, > > This method used to be called from AgentManagerImpl, but it now uses the > default constructor with Inject. So this method is no longer needed and I > decided to remove it to avoid confusion. I dislike leaving constr

RE: [ACS41][Patch request] f1259d50bdd6120174717f4cce6a45dc12b6645b

2013-04-04 Thread Hugo Trippaers
unmaintained and become broken at some point. Cheers, Hugo > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, April 04, 2013 5:01 PM > To: dev@cloudstack.apache.org > Subject: Re: [ACS41

Re: [ACS41][Patch request] f1259d50bdd6120174717f4cce6a45dc12b6645b

2013-04-04 Thread Chip Childers
On Thu, Apr 04, 2013 at 04:52:15PM +0200, Wido den Hollander wrote: > Hi, > > Hugo and I were on IRC today and he found > f1259d50bdd6120174717f4cce6a45dc12b6645b > > I also noticed this on 4.1 and this fix seems to resolve it. > > There is no Jira ticket I could find and since Hugo isn't online

[ACS41][Patch request] f1259d50bdd6120174717f4cce6a45dc12b6645b

2013-04-04 Thread Wido den Hollander
Hi, Hugo and I were on IRC today and he found f1259d50bdd6120174717f4cce6a45dc12b6645b I also noticed this on 4.1 and this fix seems to resolve it. There is no Jira ticket I could find and since Hugo isn't online right now I'm requesting it this way. Or do we want a Jira ticket first? Wid

Re: [ACS41][Patch request] CLOUDSTACK-1936

2013-04-04 Thread Chip Childers
On Thu, Apr 04, 2013 at 09:45:05AM -0400, David Nalley wrote: > Chip: > > Please pull in: > 542a339f967f504fbb7c203743808123209a4fce > > --David > Done: commit 0ef3e6dd5a0f687bbf0a4eeea1c6c8d225a636dd Author: David Nalley Date: Thu Apr 4 09:37:13 2013 -0400 CLOUDSTACK-1936 add cloudstac

[ACS41][Patch request] CLOUDSTACK-1936

2013-04-04 Thread David Nalley
Chip: Please pull in: 542a339f967f504fbb7c203743808123209a4fce --David

[ACS41][Patch Request]

2013-04-02 Thread Marcus Sorensen
Commit 04a511a1a828a829962681525780f80935a161f9 in branch refs/heads/master from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=04a511a ] CLOUDSTACK-1900 : Save a default db.properties during upgrade, and make s

Re: [ACS41][PATCH request]CLOUDSTACK-1827: Fix redundant router update mechanism

2013-03-30 Thread Chip Childers
On Thu, Mar 28, 2013 at 03:55:26PM -0700, Sheng Yang wrote: > commit e3f67d126d66c31e027c96b5524667884084053b > Author: Sheng Yang > Date: Thu Mar 28 15:02:45 2013 -0700 > > CLOUDSTACK-1827: Fix redundant router update mechanism > > There is a bug that if the smaller number ID RvR stop

Re: [ACS41][PATCH request]CLOUDSTACK-1827: Fix redundant router update mechanism

2013-03-29 Thread Chip Childers
Sorry for missing it. Will test and push in about an hour. On Mar 29, 2013, at 6:30 PM, Sheng Yang wrote: > Bump... > > --Sheng > > On Thu, Mar 28, 2013 at 3:55 PM, Sheng Yang wrote: >> commit e3f67d126d66c31e027c96b5524667884084053b >> Author: Sheng Yang >> Date: Thu Mar 28 15:02:45 2013 -0

Re: [ACS41][PATCH request]CLOUDSTACK-1827: Fix redundant router update mechanism

2013-03-29 Thread Sheng Yang
Bump... --Sheng On Thu, Mar 28, 2013 at 3:55 PM, Sheng Yang wrote: > commit e3f67d126d66c31e027c96b5524667884084053b > Author: Sheng Yang > Date: Thu Mar 28 15:02:45 2013 -0700 > > CLOUDSTACK-1827: Fix redundant router update mechanism > > There is a bug that if the smaller number ID

Re: [ACS41][Patch Request]

2013-03-29 Thread Chip Childers
On Fri, Mar 29, 2013 at 06:12:14PM +0530, Prasanna Santhanam wrote: > On Fri, Mar 29, 2013 at 01:29:33PM +0530, Prasanna Santhanam wrote: > > commit d13c18516a30d035e2251d187979e805670aab81 > > Author: Prasanna Santhanam > > Date: Fri Mar 29 13:25:20 2013 +0530 > > > > CLOUDSTACK-1841: Miss

Re: [ACS41][Patch Request]

2013-03-29 Thread Chip Childers
On Fri, Mar 29, 2013 at 10:25:23AM +, Murali Reddy wrote: > commit 48311363d600264cb3542992a615706cb92f90ad > Author: Murali Reddy > Date: Fri Mar 29 15:53:21 2013 +0530 > > CLOUDSTACK-1834: Events are not generated for registerUserKeys(), > Enabling account and Editing account. Pu

Re: [ACS41][Patch Request]

2013-03-29 Thread Prasanna Santhanam
On Fri, Mar 29, 2013 at 01:29:33PM +0530, Prasanna Santhanam wrote: > commit d13c18516a30d035e2251d187979e805670aab81 > Author: Prasanna Santhanam > Date: Fri Mar 29 13:25:20 2013 +0530 > > CLOUDSTACK-1841: Missing `cloud`.`configuration` stmts in upgrade > > Following global confi

[ACS41][Patch Request]

2013-03-29 Thread Murali Reddy
commit 48311363d600264cb3542992a615706cb92f90ad Author: Murali Reddy Date: Fri Mar 29 15:53:21 2013 +0530 CLOUDSTACK-1834: Events are not generated for registerUserKeys(), Enabling account and Editing account.

[ACS41][Patch Request]

2013-03-29 Thread Prasanna Santhanam
commit d13c18516a30d035e2251d187979e805670aab81 Author: Prasanna Santhanam Date: Fri Mar 29 13:25:20 2013 +0530 CLOUDSTACK-1841: Missing `cloud`.`configuration` stmts in upgrade Following global configurations introduced b/w 3.0.2 and 4.1 were missed. concurrent.snapsh

Re: [ACS41][Patch Request]

2013-03-28 Thread prasanna
I've applied this on 4.1 so we can test upgrades - 260f6f7e5d7adae9da0d62c530e5279aeffb6f79 On 29 March 2013 07:37, Marcus Sorensen wrote: > commit d6e11f25ace4696ec39063f86342cd8a94bd96ee > Author: Marcus Sorensen > Date: Thu Mar 28 20:03:28 2013 -0600 > > CLOUDSTACK-1844 - fix typo in

[ACS41][Patch Request]

2013-03-28 Thread Marcus Sorensen
commit d6e11f25ace4696ec39063f86342cd8a94bd96ee Author: Marcus Sorensen Date: Thu Mar 28 20:03:28 2013 -0600 CLOUDSTACK-1844 - fix typo in agent pre-script to allow copy of old configs to new config location Reported-by: Sangeetha Hariharan (JIRA) Signed-off-by: Marcus Sorensen

[ACS41][PATCH request]CLOUDSTACK-1827: Fix redundant router update mechanism

2013-03-28 Thread Sheng Yang
commit e3f67d126d66c31e027c96b5524667884084053b Author: Sheng Yang Date: Thu Mar 28 15:02:45 2013 -0700 CLOUDSTACK-1827: Fix redundant router update mechanism There is a bug that if the smaller number ID RvR stop running, that pair of RvR's status won't be updated. This patch fixed

[ACS41][Patch Request]

2013-03-27 Thread Marcus Sorensen
Commit a588efc0cc83c067dbe78bf538be32253072290a in branch refs/heads/master from Marcus Sorensen [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a588efc ] Summary: RPM - recover configs during upgrade Detail: Uninstallation of old RPMs wipes out some of the configs, and makes it dif

Re: [ACS41][Patch Request]

2013-03-27 Thread Chip Childers
On Wed, Mar 27, 2013 at 12:46:20PM -0600, Marcus Sorensen wrote: > Commit a588efc0cc83c067dbe78bf538be32253072290a in branch > refs/heads/master from Marcus Sorensen > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a588efc ] > > Summary: RPM - recover configs during upgrade > > Det

Re: [ACS41] [PATCH REQUEST] CLOUDSTACK-1804 Upgrade 4.0 -> 4.1 - DB upgrade fails.

2013-03-27 Thread Chip Childers
On Wed, Mar 27, 2013 at 12:57:49PM +, Murali Reddy wrote: > > Chip, please pull in this commit in master to 4.1 branch. > > commit f414b8a850607d20c0a78d455b4c43d90947b41f > Author: Murali Reddy > Date: Wed Mar 27 18:06:22 2013 +0530 > > CLOUDSTACK-1804:Upgrade 4.0 -> 4.1 - DB upgrade fai

RE: [ACS41] [PATCH REQUEST] CLOUDSTACK-1804 Upgrade 4.0 -> 4.1 - DB upgrade fails.

2013-03-27 Thread Sudha Ponnaganti
: dev@cloudstack.apache.org Subject: [ACS41] [PATCH REQUEST] CLOUDSTACK-1804 Upgrade 4.0 -> 4.1 - DB upgrade fails. Chip, please pull in this commit in master to 4.1 branch. commit f414b8a850607d20c0a78d455b4c43d90947b41f Author: Murali Reddy Date: Wed Mar 27 18:06:22 2013 +0530 CLOUDST

[ACS41] [PATCH REQUEST] CLOUDSTACK-1804 Upgrade 4.0 -> 4.1 - DB upgrade fails.

2013-03-27 Thread Murali Reddy
Chip, please pull in this commit in master to 4.1 branch. commit f414b8a850607d20c0a78d455b4c43d90947b41f Author: Murali Reddy Date: Wed Mar 27 18:06:22 2013 +0530 CLOUDSTACK-1804:Upgrade 4.0 -> 4.1 - DB upgrade fails. remove the data migration functions that were accidently introduced by co

RE: [ACS41] [PATCH REQUEST] - CLOUDSTACK 1008

2013-03-26 Thread Pranav Saxena
Thanks Chip! Regards, Pranav -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, March 26, 2013 7:56 PM To: Pranav Saxena Cc: cloudstack-...@incubator.apache.org Subject: Re: [ACS41] [PATCH REQUEST] - CLOUDSTACK 1008 On Tue, Mar 26, 2013 at 10:46

Re: [ACS41] [PATCH REQUEST] - CLOUDSTACK 1008

2013-03-26 Thread Chip Childers
On Tue, Mar 26, 2013 at 10:46:38AM +, Pranav Saxena wrote: > > Hi Chip, > > Could you please apply the patch attached to this JIRA ticket - > https://issues.apache.org/jira/browse/CLOUDSTACK-1008 ? It seems it's > specific to 4.1 and hence I haven't committed it to master. > > Thanks, > P

[ACS41] [PATCH REQUEST] - CLOUDSTACK 1008

2013-03-26 Thread Pranav Saxena
Hi Chip, Could you please apply the patch attached to this JIRA ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-1008 ? It seems it's specific to 4.1 and hence I haven't committed it to master. Thanks, Pranav From e1a9062e1c5d27e5b7a63d4f00c783112a1d3558 Mon Sep 17 00:00:00 2001 From

Re: [ACS41][Patch Request]

2013-03-25 Thread Chip Childers
On Mon, Mar 25, 2013 at 09:49:10AM -0600, Marcus Sorensen wrote: > commit 8eb3ebbe1abc6b33b28c58ff3cd4090dd78da58b > Author: Marcus Sorensen > Date: Mon Mar 25 09:44:44 2013 -0600 > > Summary: CLOUDSTACK-1565 - Waits for ip to come up before setting > default route > > Submitted-by: Ja

[ACS41][Patch Request]

2013-03-25 Thread Marcus Sorensen
commit 8eb3ebbe1abc6b33b28c58ff3cd4090dd78da58b Author: Marcus Sorensen Date: Mon Mar 25 09:44:44 2013 -0600 Summary: CLOUDSTACK-1565 - Waits for ip to come up before setting default route Submitted-by: Jayapal Reddy Signed-off-by: Marcus Sorensen 1364226284 -0600

Re: [ACS41][Patch Request] CLOUDSTACK-1625: NPE with updateResourceCount when && is passed thru API

2013-03-22 Thread Chip Childers
On Fri, Mar 22, 2013 at 05:45:48AM +, Likitha Shetty wrote: > Already checked in master. > > CLOUDSTACK-1625. NPE with updateResourceCount when && is passed thru API. > If any API contains '&' i.e. no key value pair or '&' i.e. a > parameter without a value, then we get an NPE as > owasp.esa

Re: [ACS41][Patch Request] CLOUDSTACK-1028 Fix documentation related to new egress rules feature

2013-03-22 Thread Chip Childers
On Thu, Mar 21, 2013 at 08:31:24PM -0700, Jessica Tomechak wrote: > OK Chip! > > On Thu, Mar 21, 2013 at 8:28 PM, Chip Childers > wrote: > > > Docs can be committed directly. Please do so. > > > > On Mar 21, 2013, at 11:27 PM, Jessica Tomechak > > wrote: > > > > > I've made a commit to master t

Re: [ACS41][Patch Request] CLOUDSTACK-866 Documentation for API Request Throttling

2013-03-22 Thread Chip Childers
On Thu, Mar 21, 2013 at 08:30:56PM -0700, Jessica Tomechak wrote: > I've committed docs in master for the new 4.1 feature API Request > Throttling. The eng bug for the feature is CLOUDSTACK-618, and the doc > subtask bug is CLOUDSTACK-866. The commit hash in master is: > > 976a5fa788863cd955b279ae

[ACS41][Patch Request] CLOUDSTACK-1625: NPE with updateResourceCount when && is passed thru API

2013-03-21 Thread Likitha Shetty
Already checked in master. CLOUDSTACK-1625. NPE with updateResourceCount when && is passed thru API. If any API contains '&' i.e. no key value pair or '&' i.e. a parameter without a value, then we get an NPE as owasp.esapi.StringUtilities.stripControls deosn't handle NPE. Branch: refs/heads/mas

Re: [ACS41][Patch Request] CLOUDSTACK-1028 Fix documentation related to new egress rules feature

2013-03-21 Thread Jessica Tomechak
OK Chip! On Thu, Mar 21, 2013 at 8:28 PM, Chip Childers wrote: > Docs can be committed directly. Please do so. > > On Mar 21, 2013, at 11:27 PM, Jessica Tomechak > wrote: > > > I've made a commit to master that should be added to 4.1, please: > > > > b1e61cc94a6a4e3cf89a5fc345b54bfa36c6d4ec > >

[ACS41][Patch Request] CLOUDSTACK-866 Documentation for API Request Throttling

2013-03-21 Thread Jessica Tomechak
I've committed docs in master for the new 4.1 feature API Request Throttling. The eng bug for the feature is CLOUDSTACK-618, and the doc subtask bug is CLOUDSTACK-866. The commit hash in master is: 976a5fa788863cd955b279ae571c88c9f0ed1e18 Could this be added to 4.1, please? Thanks, Jessica T.

Re: [ACS41][Patch Request] CLOUDSTACK-1028 Fix documentation related to new egress rules feature

2013-03-21 Thread Chip Childers
Docs can be committed directly. Please do so. On Mar 21, 2013, at 11:27 PM, Jessica Tomechak wrote: > I've made a commit to master that should be added to 4.1, please: > > b1e61cc94a6a4e3cf89a5fc345b54bfa36c6d4ec > > The section "Firewall Rules" seems to have been deleted when the new > "Egress

[ACS41][Patch Request] CLOUDSTACK-1028 Fix documentation related to new egress rules feature

2013-03-21 Thread Jessica Tomechak
I've made a commit to master that should be added to 4.1, please: b1e61cc94a6a4e3cf89a5fc345b54bfa36c6d4ec The section "Firewall Rules" seems to have been deleted when the new "Egress Firewall Rules" section was added for CLOUDSTACK-1028. The first section is about ingress rules, so I'm pretty su