RE: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-26 Thread Jessica Wang
Vetrivel, Mike has reviewed it. Mike, thanks a lot! Jessica From: Vetrivel Chinnasamy Sent: Thursday, June 26, 2014 5:07 AM To: Mike Tutkowski; dev@cloudstack.apache.org Cc: Brian Federle; Alena Prokharchyk; Jessica Wang Subject: RE: [ACS4.4] i18n problems in Add Primary Storage dialog Hi Mike

Re: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-26 Thread Mike Tutkowski
:56 > *To:* dev@cloudstack.apache.org; Vetrivel Chinnasamy > *Cc:* Brian Federle; Alena Prokharchyk; Jessica Wang > *Subject:* Re: [ACS4.4] i18n problems in Add Primary Storage dialog > > > > By the way, what I was referring to with my proposed hack was just to fix

RE: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-26 Thread Vetrivel Chinnasamy
issues. From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: 26 June 2014 03:56 To: dev@cloudstack.apache.org; Vetrivel Chinnasamy Cc: Brian Federle; Alena Prokharchyk; Jessica Wang Subject: Re: [ACS4.4] i18n problems in Add Primary Storage dialog By the way, what I was referring to w

Re: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-25 Thread Mike Tutkowski
By the way, what I was referring to with my proposed hack was just to fix the two situations ("SR Name-Label" and "Path") by hardcoding the English back in. On Wed, Jun 25, 2014 at 2:34 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > It looks like these issues were introduced in > 18

Re: [ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-25 Thread Mike Tutkowski
It looks like these issues were introduced in 182c31899bb353eac66a43ca4e81117c4fd06332 by vetrivelc with regards to externalizing hardcoded strings. My guess is that this substitution was done in an automated fashion and some unintended consequences of the substitution logic occurred. vetrivelc -

[ACS4.4] i18n problems in Add Primary Storage dialog

2014-06-25 Thread Mike Tutkowski
Hi, I noticed a couple i18n-related issues in the Add Primary Storage dialog: 1) label.path shows up literally as label.path (instead of Path) 2) label.SR.name shows up literally as label.SR.name (instead of SR Name-Label) I looked at the applicable i18n/l10n files and all looked well. Once I