Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread Daan Hoogland
H Hiroki, those calls are for ServiceOfferingVO not for VMInstanceVO. So they are not the same issue but that doesn't mean that we shouldn't those the be counted when deleted either. On Thu, May 29, 2014 at 12:11 PM, Hiroki Ohashi wrote: > Hi Daan, Rajani > > I looked at a code of master and 4.4

Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread Hiroki Ohashi
Hi Daan, Rajani I looked at a code of master and 4.4 branch. findById is used at line 3031 of master branch and line 3299 of 4.4 branch, so I think this leads to an same problem. The code snippets of master and 4.4 branch are below. [master] server/src/com/cloud/api/ApiResponseHelper.java 298

Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread sebgoa
On May 29, 2014, at 11:20 AM, Rajani Karuturi wrote: > The fix is already in 4.4 > > commit 3a3457e7132d22f52aa38179d40a6eb9b0b29677 > Author: Sam Schmit > AuthorDate: Fri May 2 13:07:34 2014 -0500 > Commit: Daan Hoogland > CommitDate: Tue May 6 17:46:20 2014 +0200 > >CLOUDSTACK

Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread Rajani Karuturi
The fix is already in 4.4 commit 3a3457e7132d22f52aa38179d40a6eb9b0b29677 Author: Sam Schmit AuthorDate: Fri May 2 13:07:34 2014 -0500 Commit: Daan Hoogland CommitDate: Tue May 6 17:46:20 2014 +0200 CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixi

Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread Daan Hoogland
Hiroki, Did you have a look at 4.4 or master as well? tell us when it works, so we can cherry-pick the fix to later versions. On Thu, May 29, 2014 at 10:25 AM, Hiroki Ohashi wrote: > sebgoa > > > 2014-05-29 16:52 GMT+09:00 sebgoa : >> >> On May 29, 2014, at 9:26 AM, Hiroki Ohashi wrote: >> >>>

Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread Hiroki Ohashi
sebgoa 2014-05-29 16:52 GMT+09:00 sebgoa : > > On May 29, 2014, at 9:26 AM, Hiroki Ohashi wrote: > >> Dear guys >> >> I found a bug about listUsageRecords API in 4.3 related to a issue >> CLOUDSTACK-6472 and made a patch. Would you review the patch and >> correct me if I am wrong? >> >> Sam Schm

Re: [ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread sebgoa
On May 29, 2014, at 9:26 AM, Hiroki Ohashi wrote: > Dear guys > > I found a bug about listUsageRecords API in 4.3 related to a issue > CLOUDSTACK-6472 and made a patch. Would you review the patch and > correct me if I am wrong? > > Sam Schmit push a commit about NPEs/Null UUIDs at May 5th but

[ACS 4.3] listUsageRecords API bug related to CLOUDSTACK-6472

2014-05-29 Thread Hiroki Ohashi
Dear guys I found a bug about listUsageRecords API in 4.3 related to a issue CLOUDSTACK-6472 and made a patch. Would you review the patch and correct me if I am wrong? Sam Schmit push a commit about NPEs/Null UUIDs at May 5th but I think his commit is not enough. commit e8047e11db7ef2bdc44bb