Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
OK, just an FYI that the version-checking code I put in based on Marcus' comments worked. I can now live migrate the VM. I plan to open a PR for this later tonight. On Mon, Aug 31, 2015 at 1:49 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > I see a test was failing: LibvirtComputing

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
I see a test was failing: LibvirtComputingResourceTest.testMigrateCommand. I'm not sure if you can do an "or" with Mockito, but I changed a check to the following and it passes now (it was failing because a 1 was being passed in now instead of an 8 on my platform): try { veri

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
This is probably more esthetically pleasing to most people (and simpler looking): CVE-2015-3252: Get XML with sensitive information suitable for migration by using VIR_DOMAIN_XML_MIGRATABLE flag (value = 8) https://libvirt.org/html/libvirt-libvirt-

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
Sounds good Does this look reasonable (I haven't tested it yet): CVE-2015-3252: Get XML with sensitive information suitable for migration by using VIR_DOMAIN_XML_MIGRATABLE flag (value = 8) https://libvirt.org/html/libvirt-libvirt-domain.html#virD

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
Might as well put the check in, to ensure we don't try to use flags that aren't available. On Mon, Aug 31, 2015 at 10:21 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Thanks, everyone > > Marcus - Do you think I should put in a version check or is that version of > Libvirt too old t

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Mike Tutkowski
Thanks, everyone Marcus - Do you think I should put in a version check or is that version of Libvirt too old to bother supporting? On Monday, August 31, 2015, Marcus wrote: > Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0 > (version 100 in how the Libvirt API reports

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
Looks like the VIR_DOMAIN_XML_MIGRATABLE flag was introduced in v1.0.0 (version 100 in how the Libvirt API reports), and VIR_DOMAIN_XML_SECURE was all the way back in v0.8.0 (version 8000). On Mon, Aug 31, 2015 at 8:04 AM, Marcus wrote: > There are a bunch of things like this in the code alr

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Marcus
There are a bunch of things like this in the code already, and they're wrapped in version checks. See _hypervisorLibvirtVersion in LibvirtComputingResource. We just need to figure out which versions need to be left out. On Mon, Aug 31, 2015 at 1:56 AM, Rohit Yadav wrote: > Hi Mike, > > I thi

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Rohit Yadav
Hi Mike, I think it is related to this, the libvirt version is really old that lacks the flags: https://github.com/apache/cloudstack/commit/5d29b63cfa98a15d7734798c5b29a43658d7f112 If VM migration flag (8) is not available, can you check if VIR_DOMAIN_XML_SECURE (flag=1) works for you, if so we

Re: [4.6] Error migrating VM from KVM host

2015-08-31 Thread Wido den Hollander
On 08/31/2015 07:59 AM, Mike Tutkowski wrote: > Hi, > > I'm having a problem migrating a VM from one 12.04 KVM host to another > 12.04 KVM host in the same cluster in CS 4.6. > > Anyone know why I might be receiving this error message? > > invalid argument: virDomainDefFormat: unsupported flag

Re: [4.6] Error migrating VM from KVM host

2015-08-30 Thread Mike Tutkowski
As a point of comparison, I just ran an identical test using 14.04 KVM hosts and it worked. On Sun, Aug 30, 2015 at 11:59 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Hi, > > I'm having a problem migrating a VM from one 12.04 KVM host to another > 12.04 KVM host in the same cluster

[4.6] Error migrating VM from KVM host

2015-08-30 Thread Mike Tutkowski
Hi, I'm having a problem migrating a VM from one 12.04 KVM host to another 12.04 KVM host in the same cluster in CS 4.6. Anyone know why I might be receiving this error message? invalid argument: virDomainDefFormat: unsupported flags (0x8) The root disk is stored on cluster-scoped NFS primary s