[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-09 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110319573 @rsafonseca I didn't apply this patch indeed. It requires JAVA class re-compilation and I don't dare to make it directly at production. JS was not s

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-09 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110282737 @rsafonseca I didn't get it. Don't have so deep knowledge about cookie manipulation. If I open dev-tools at Chrome I can see only 1 cookie

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-09 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110271962 @rsafonseca Can you help me to define the correct internal domain name? If I check cookie at plain HTTP server (where it works) I see **domainid** field with

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-09 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110259230 @rsafonseca I have added Set-Cookie and P3P lines into config. My $host variable contains either kickcloud.net or www.kickcloud.net -- depends on request user

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110004148 @rsafonseca Thank you for explanation. I will try to put my points here: 1. For public cloud HTTPS must be used (this is not an option) and external SSL

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-109960026 I have applied you patch manually and it worked for HTTP. I have expected that if I put HTTPS proxy in front of it - it will continue to work. But at HTTPS

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-109923828 I have recently implemented SSL proxy in front of CS. This way seems to be more practical than deploying certificates directly into Tomcat. After such

[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed merge conflicts wi...

2015-05-29 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/302#issuecomment-106997127 I have checked 4.5/master and it looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-27 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105861384 Have tested with 4.5.1 -- works good ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed merge conflicts wi...

2015-05-26 Thread vadimkim
GitHub user vadimkim opened a pull request: https://github.com/apache/cloudstack/pull/302 CLOUDSTACK-8231: fixed merge conflicts with previous patch We need to port this update to 4.5 branch as well. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8231: reverted 7ee9b10 commit ...

2015-05-26 Thread vadimkim
Github user vadimkim closed the pull request at: https://github.com/apache/cloudstack/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8231: reverted 7ee9b10 commit ...

2015-05-21 Thread vadimkim
GitHub user vadimkim opened a pull request: https://github.com/apache/cloudstack/pull/274 CLOUDSTACK-8231: reverted 7ee9b10 commit logic Have done 2 commits and created 2 different pull requests. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed call to getLbAlgor...

2015-05-21 Thread vadimkim
Github user vadimkim commented on the pull request: https://github.com/apache/cloudstack/pull/273#issuecomment-104170005 2 commits in a raw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed call to getLbAlgor...

2015-05-21 Thread vadimkim
Github user vadimkim closed the pull request at: https://github.com/apache/cloudstack/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed call to getLbAlgor...

2015-05-21 Thread vadimkim
GitHub user vadimkim opened a pull request: https://github.com/apache/cloudstack/pull/273 CLOUDSTACK-8231: fixed call to getLbAlgorithms() function Context must be not empty before calling getLbAlgorithms() function, so previous commit may cause side-effects while trying to get LB

[GitHub] cloudstack pull request: CLOUDSTACK-8231: Fixed UI empty drop-down...

2015-05-20 Thread vadimkim
GitHub user vadimkim opened a pull request: https://github.com/apache/cloudstack/pull/271 CLOUDSTACK-8231: Fixed UI empty drop-down list for LB rules It seems that getLbAlgorithms() function must be called if context is "undefined". If context is defined then functi