Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/555
Continuing with the code changes here in a new PR #1875. This PR will be
closed when PR #1875 is merged.
---
If your project is set up for it, you can reply to this email and have your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Changes in the PR #2019.
Maximum data volumes supported field, in the _hypervisor_capabilities_
table, should be the attachable data volumes to the VM. This excludes the ROOT
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@karuturi Can you merge this PR. Current base branch is 4.9. Is that OK or
Shall I change to master?
---
If your project is set up for it, you can reply to this email and have your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd This PR has 2 LGTMs, is targeted to 4.9. Can you merge this PR to
4.9 or Shall I change the base branch to master?
---
If your project is set up for it, you can reply to this
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1880
The above tests failure are not related to this PR. These are failing most
for the other PRs.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd Please kick off VMware tests on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@nvazquez Updated the code for the issue reported. Can you please re-test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@karuturi I'm working on the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@nvazquez Thanks for testing. I'll check and update accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/837
Code changes LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105888712
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@rafaelweingartner Thanks for reviewing, will work on the changes suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105722036
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@rhtyd @karuturi Could see vSphere 4.1 in the latest installation guide.
Please note that this documentation needs to be updated at some point later.
> vSphere and vCenter, versi
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@serg38 Copying port groups from the oldest host in the cluster to the new
host for DRS compatible. I'll check this with the hosts returning from
Maintenance. Thanks.
---
If
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@rhtyd @karuturi Is this documented in any of the earlier release notes.
Can we remove the config param "vmware.ports.per.dvportgroup" if vSphere 4.x is
not supported?
-
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@nvazquez @serg38 Please review the code changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@nvazquez @serg38 Can you please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@resmo You have already reviewed the PR# 1248. This was the clean PR raised
out of the same. Can you please take a look.
---
If your project is set up for it, you can reply to this
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1875#discussion_r105573382
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -707,6 +709,23 @@ private String
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1878#discussion_r105573097
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2071,6 +2120,14 @@ protected
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@PaulAngus What was the error shown for duplicate MAC in vCenter. Can you
post the log snippet with the error. These changes were tested in vCenter 5.5
and 6.0, didn't observe any i
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd Retargeted this PR to 4.9. Please re-run the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@nvazquez can you please re-verify?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@nvazquez Thanks for testing the changes. Tested these changes in ESXi
6.0.0, Build 3620759 on vCenter 60U2. I had already looked at the link you
provided while fixing this. I observed
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd thanks for running tests. The intermittent failures reported above
are not related to this PR. These tests are also failing most of the time in
other PRs as well.
---
If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1880
@borisstoyanov @rhtyd Can you please run VMware tests of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1891
@borisstoyanov Can you please kick off tests for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1891
@borisstoyanov the existing tests with space in the host name should work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1891
@jburwell Thanks for the recommendation. Not changing the visibility for
now. Couldn't find any tests for VmwareServerDiscoverer to update. Will try to
add.
---
If your project i
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@nvazquez @serg38 I tested this fix on VMware vSphere 5.5 and 6.0. I'll
re-verify this on 6.0. Can you please share the build# of ESXi 6.
---
If your project is set up for it, yo
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1875#discussion_r104373535
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -707,6 +709,23 @@ private String
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@nvazquez @serg38 Please review the code changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@rhtyd Above failures in the test results are not related to the changes in
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@rhtyd @borisroman can you kick off vmware tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@sateesh-chodapuneedi These two test failures are due to the ssh failure to
the router VM, are not related to this PR changes
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
Please ignore the above BVT test results from @cloudmonger. These tests
were executed on xenserver instead of VMware.
---
If your project is set up for it, you can reply to this email
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
Please ignore the above BVT test results from @cloudmonger. These tests
were executed on xenserver instead of VMware. VMware tests has been kicked off
in @blueorangutan
---
If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@priyankparihar Perfect. Code changes LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r103409558
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/669
Tested manually. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1880
@rhtyd Can you please kick off the tests again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1897
The failed test cases above are not related to this PR changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102651816
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102650751
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102650370
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2073,6 +2089,43 @@ protected
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r102649977
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -703,6 +703,16 @@ private Answer
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/669
@anshul1886 Please address the open questions and rebase. Post the latest
test results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
@rhtyd Can you please run trillian tests for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1253
Moved the schema changes to 4920-41000 upgrade path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@rhtyd Can you kick off VMware CI on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102539843
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -584,18 +584,36 @@ public void
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102539356
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1875
@sateesh-chodapuneedi @rhtyd Please review the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1875
@rhtyd Thanks for running tests. The test failures/errors above are failing
in other PRs as well, not related to the changes in this PR.
---
If your project is set up for it, you can
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@remibergsma Same MAC for RVR has been re-introducted as part of
[CLOUDSTACK-985](https://issues.apache.org/jira/browse/CLOUDSTACK-985). It
confirms that peer NICs of RVRs should have
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@sateesh-chodapuneedi @rhtyd Please review the code changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd Thanks for running these test. The failures/errors are not related
to this PR changes.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1897
@koushik-das @kishankavala Please review the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1897
@ramkatru Checked and addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@borisstoyanov Can you kick off Jenkins job on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102311697
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -716,11 +734,6 @@ public DiskFmtType
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@remibergsma @borisstoyanov Updated the KVM code to generate the valid
device name above id 25.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102309898
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303566
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303488
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303229
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102302052
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301869
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301645
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@borisstoyanov Can you please run trillian tests for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@rafaelweingartner Updated the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@rafaelweingartner Sure. I'll move these lines to a method and push the
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1953
@remibergsma The KVM support for max data volumes 32 was updated in the DB
as part of CLOUDSTACK-8992 (PR #980). CloudStack supports till device Id 15,
without this changes. Might be the
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@rhtyd Can you kick off VMware CI on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1875
@rhtyd Can you run VMware CI on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1880
@rhtyd Can you run VMware CI on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1891
@rhtyd Can you kick off VMware CI on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1953
CLOUDSTACK-9794: Unable to attach more than 14 devices to a VM
Updated hardcoded value with max data volumes limit from hypervisor
capabilities.
You can merge this pull request into a
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1818
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/927
Code changes looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1892
@koushik-das, UI screenshots of hardcoded label on the Add zone wizard and
the UI fix for it are attached. Please check.
 appears on the Add
zone wizard
You can merge this pull request into
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1891
CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to
existing VMware cluster
Issue: Unable to add a host with space in its name to existing VMware
cluster
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1882
CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not
required based on persistent VR changes.
You can merge this pull request into a Git repository by running
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1862
@sateesh-chodapuneedi Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1841
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1862#discussion_r94206268
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -5620,4 +5623,39 @@ private String
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1880
Validated that the template_size is getting updated correctly in
template_spool_ref table.
Prior to the fix, the size was logged as 0 =>
mysql> select id,template_id,templat
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1881
CLOUDSTACK-9721: Remove deprecated/unused global configuration parameter -
consoleproxy.loadscan.interval
You can merge this pull request into a Git repository by running:
$ git
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1880
CLOUDSTACK-9720: [VMware] template_spool_ref table is not getting updated
with correct template physical size in template_size column.
Updated the template_spool_ref table with the
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1879
CLOUDSTACK-9719: [VMware] VR loses DHCP settings and VMs cannot obtain IP
after HA recovery - Set high restart priority for the VR.
[VMware] VR loses DHCP settings and VMs cannot obtain
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1878
CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra
public NICs.
Problem:
[VMware] RVRs have mismatching MAC addresses for extra public NICs.
Root Cause
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1875
CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions
issue. Provide permissions to template folder when mounted on management server.
[VMware] System VMs failed to
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1794
@rhtyd Added more guest OS mappings and rebased against latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1257
@rhtyd Changed base branch to 4.9 and rebased against 4.9. This would be
useful for 4.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd no existing marvin test for this. will add the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd Rebased against 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd Addressed the changes suggested and rebased against latest master.
Tested this manually.
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 140 matches
Mail list logo