[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-19 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-197905351 If the concern is jenkins build, I mentioned that they are not related to these integration test code but they are junit tests. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-19 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-197904292 @swill Yes, PR is ready to be merged. Do you see any problem with that? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-19 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-197927026 sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-14 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-196653502 otherwise, it LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-14 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-196653459 Jenkins failure is not related to these integration test changes, there are some junit tests failed [ERROR] Failed to execute goal

[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-11 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-195391894 @sneeladh @shivsg Thanks for adding the tests, can you please run your code through pyflakes, pep8 and fix them ? $ pyflakes *.py

[GitHub] cloudstack pull request: Change references to people.apache.org to...

2015-11-25 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/1123#issuecomment-159821904 @karuturi Reverted the commit on master and 4.6 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Change references to people.apache.org to...

2015-11-25 Thread srikanteswartalluri
GitHub user srikanteswartalluri opened a pull request: https://github.com/apache/cloudstack/pull/1123 Change references to people.apache.org to home.apache.org in the test… … code Signed-off-by: SrikanteswaraRao Talluri You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-08-10 Thread srikanteswartalluri
Github user srikanteswartalluri closed the pull request at: https://github.com/apache/cloudstack/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-08-10 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/158#issuecomment-129546119 Folks, i am closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8593: assign __testName if it ...

2015-06-28 Thread srikanteswartalluri
GitHub user srikanteswartalluri opened a pull request: https://github.com/apache/cloudstack/pull/537 CLOUDSTACK-8593: assign __testName if it is not getting set from test Signed-off-by: SrikanteswaraRao Talluri You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: CLOUDSTACK-8375: Marvin - Code Improvemen...

2015-04-13 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/155#issuecomment-92619011 This is merged. forgot to add 'This closes #155' Gaurav, Please close this PR. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-04-13 Thread srikanteswartalluri
GitHub user srikanteswartalluri opened a pull request: https://github.com/apache/cloudstack/pull/158 CLOUDSTACK-8379:add support to marvin to enable deployed zone based on t... ...he value provided in config file You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: Hosts without tag are not listed while li...

2015-04-08 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/149#issuecomment-90927245 looks good to me. your master branch has some extra commits. I am taking the patch. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Resetvm

2015-04-08 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/148#issuecomment-90835989 looks good, committed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8361: Adding functionality in ...

2015-04-03 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/144#issuecomment-89240323 well written. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-01 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/138#issuecomment-88418770 Looks good. Can you rebase it with latest master? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Sadhu

2015-03-30 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/135#issuecomment-87629689 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8344: Fixed SSH failures in te...

2015-03-29 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/130#issuecomment-87555204 Good catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Vcenter marvin library

2015-03-29 Thread srikanteswartalluri
GitHub user srikanteswartalluri opened a pull request: https://github.com/apache/cloudstack/pull/134 Vcenter marvin library https://issues.apache.org/jira/browse/CLOUDSTACK-8352 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: CLOUDSTACK-8340: Adding test case for sto...

2015-03-23 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/122#issuecomment-84935073 It will be easier to focus on the new tests if you keep pep8 issues separate from the intended patch. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8336: Adding tests for shared ...

2015-03-20 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/120#issuecomment-83993591 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8330: Tagging test cases which...

2015-03-20 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/121#issuecomment-83984324 Looks good. As this change is only related to tagging the tests, i am not waiting for the CI build result to merge --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-7632:Automation for volume lif...

2014-11-02 Thread srikanteswartalluri
Github user srikanteswartalluri closed the pull request at: https://github.com/apache/cloudstack/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if