[GitHub] cloudstack pull request: Fixed issue: UI labels are display with k...

2015-09-07 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/781#issuecomment-138284842 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2015-09-06 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/780 CLOUDSTACK-8800 : Improved the listVirtualMachines API call to include memory utilization information for a VM for xenserver,hyperv and for vmware. You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2015-09-06 Thread manuiiit
Github user manuiiit closed the pull request at: https://github.com/apache/cloudstack/pull/774 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2015-09-03 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/774 CLOUDSTACK-8800 : Improved the listVirtualMachines API call to include memory utilization information for a VM for xenserver,hyperv and for vmware You can merge this pull request into a Git

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-09 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/658#issuecomment-129300171 @remibergsma I used it for debugging purpose as a build failed.Removed it now.Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-07 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/658#issuecomment-128686845 @wido Ya I checked it.Any user was able to change permissions of the template.Updated the description with a case i tried. --- If your project is set up for it

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

2015-08-06 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-128614235 @mike-tutkowski I understood what u said.Updated.Will keep it in mind from next time.Thanks :) . --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

2015-08-06 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-128602113 @mike-tutkowski I did not find any other possibility where createPhysicalDisk would return null unless is called from NfsManagedStorageAdaptor class.Please

[GitHub] cloudstack pull request: CLOUDSTACK-8714 Restore VM (Re-install VM...

2015-08-06 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/659#issuecomment-128587836 @remibergsma It was an internal bug reported hence created a new issue and updated .Thanks for the review. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...

2015-08-06 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/662 CLOUDSTACK-8711: public_ip type resource count for an account is not decremented upon IP range deletion Probleam: -- When you add an IP range and associate it

[GitHub] cloudstack pull request: CLONE - Restore VM (Re-install VM) with e...

2015-08-05 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/659 CLONE - Restore VM (Re-install VM) with enable.storage.migration set to false fails .later fails to start up VM too Author: Prachi Damle Changes: - Try to reuse the

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-05 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/658 Implemented condition that only admin or owner of the template can change its permissions . using updateTemplatePermissions API You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: Only admin or owner of the template can c...

2015-08-05 Thread manuiiit
Github user manuiiit closed the pull request at: https://github.com/apache/cloudstack/pull/648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Only admin or owner of the template can c...

2015-07-31 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/648 Only admin or owner of the template can change its permissions using updateTemplatePermissions API You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

2015-07-28 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/630 Fixed Coverity issue "Dereference null return value" Fixed Coverity issue "Dereference null return value" You can merge this pull request into a Git repository by runn

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

2015-07-23 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/620 Fixed Coverity issue "Dereference null return value" You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuiiit/cloudst

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

2015-07-22 Thread manuiiit
Github user manuiiit commented on the pull request: https://github.com/apache/cloudstack/pull/617#issuecomment-123998699 Hi Wilder, The LibvirtBackupSnapshotCommandWrapper class has no unit tests.Can I add test cases that covers the exception. Regards

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

2015-07-22 Thread manuiiit
GitHub user manuiiit opened a pull request: https://github.com/apache/cloudstack/pull/617 Added a null value exception in LibvirtBackupSnapshotCommandWrapper.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuiiit