Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-149296707
There's a reason why the MySQL connector is not a dependency - it is Cat-X
licensed, which means we may not depend on it in the default build.
---
If your pr
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/951#issuecomment-149260232
Thanks for the patch!
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-146813771
So several questions:
1. What versions of ACS does this affect?
2. What tests were failing (if any)?
3. What tests need to be added so we don't h
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack-www/pull/13#issuecomment-135177633
I didn't take it as a -1, or I would have reverted my change. I just
finished pushing the change and didn't want you to think I was ignoring your
comm
Github user ke4qqq closed the pull request at:
https://github.com/apache/cloudstack-www/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack-www/pull/13#issuecomment-135171269
Well I just committed this change, prior to seeing @terbolous comment. - so
I'll close this, but we do indeed need to figure out how we want to do this.
-
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack-www/pull/12#issuecomment-135159546
Merged this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ke4qqq closed the pull request at:
https://github.com/apache/cloudstack-www/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack-www/pull/13#issuecomment-135159647
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ke4qqq closed the pull request at:
https://github.com/apache/cloudstack/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/746#issuecomment-135080603
LGTM - I am going to close and open to see if Travis will pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-135079970
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack-www/pull/12#issuecomment-135079648
@thinktwo Sorry this has languished so long. This LGTM +1@runseb mind
giving another +1?
---
If your project is set up for it, you can reply to this email
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/372#issuecomment-110152435
We can't bundle mysql-connector-java. It is licensed as GPL which is CatX
and thus verboten. We can make it a system dependency.
---
If your project is set u
Github user ke4qqq commented on the pull request:
https://github.com/apache/cloudstack/pull/52#issuecomment-65904635
Looks sane to me - feel free to push to 4.5 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
15 matches
Mail list logo
