Github user insom commented on the issue:
https://github.com/apache/cloudstack/pull/1451
@ustcweizhou A _side effect_ of this PR is setting the minimal timeout to
120, but that's what the original code intended - except that because of not
passing through the timeo
Github user insom commented on the issue:
https://github.com/apache/cloudstack/pull/1451
I got contacted directly by someone else hit by this bug and looking for a
fix. They saw I had commits relating to their problem. What needs to happen to
get it merged?
---
If your project is
Github user insom commented on the issue:
https://github.com/apache/cloudstack/pull/1451
@bvbharatk Hi, am I supposed to do something with this CI output? It looks
like all of the errors are related to other parts of CloudStack that aren't
touched by my commits. I came back to
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219663341
@swill rebased and pushed. It does have two LGTMs and tests by real people
(plus it's in production at here at iWeb) if that makes it a little easier to
ove
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219101084
@swill Hmm. Now it's a _different_ Cobertura error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219085734
@swill I've closed and re-opened. This change is to a shell script only and
the failures are within Marvin, so I'm pretty confident that they are unrela
Github user insom closed the pull request at:
https://github.com/apache/cloudstack/pull/1513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user insom reopened a pull request:
https://github.com/apache/cloudstack/pull/1513
CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations
(4.8-2)
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362):
>
https://github.
Github user insom closed the pull request at:
https://github.com/apache/cloudstack/pull/1512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1513
CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations
(4.8-2)
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362):
>
https://github.
Github user insom closed the pull request at:
https://github.com/apache/cloudstack/pull/1508
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1508#issuecomment-213441018
#1512 is the new version of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1512
CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations
(4.8)
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362):
>
https://github.
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1508#issuecomment-213431813
@swill Thanks! Should I rebase this against the latest 4.8 branch then? I
don't think I can change where a PR is based against, so I think I'd need to
ope
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1508
CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362):
>
https://github.com/apa
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-202951746
@pedro-martins Thanks for the review but I don't want to make this change
because (a) it'll mix two intents into on PR - fixing the bug *and* improving
t
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-201620444
@alexandrelimassantana Agreed, thanks for the review. I've added a commit
removing the prototype with the default. That has allowed me to remove that if
altog
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1451
CLOUDSTACK-9319: Use timeout when applying config to virtual router
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9319):
> The timeout parameter is not pas
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151859204
Hi @remibergsma - it looks like this Jenkins job is disabled?
https://builds.apache.org/job/cloudstack-pull-requests/ -- I can confirm the
tests pass on my rebased
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151805043
@remibergsma Travis seems happy but Jenkins isn't (but I can't view the
Jenkins output, it's 404ing :|). I'll run the tests for the rebased versi
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151097482
@remibergsma Hi, rebased and pushed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/866#issuecomment-142211053
I really like the look of this feature. I don't want to come across as too
negative with respect to some niggles with the code formatting.
---
If your project i
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/848
Pass LbProtocol down to the HAProxyConfigurator
This will let us specify a new load balancer protocol
(tcp-proxy) which enables HAProxy's `send-proxy`
functionality.
`send-
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-134932108
Not sure if @bhaisaab's comment about improvement is directed at me or
@wido. If it was at me, I'd prefer if this could be merged (as it's in the
curr
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/696
Default to notify only script to handle non-CLVM/QCOW cases.
This relates to
[CLOUDSTACK-8732](https://issues.apache.org/jira/browse/CLOUDSTACK-8732)
Before this commit the call to
25 matches
Mail list logo
