[GitHub] cloudstack pull request: CLOUDSTACK-9238: Fix URL length to 2048 f...

2016-05-27 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1567#issuecomment-222140436 Seems to break the registerIso command here... Will check exactly why. `` 2016-05-27 15:01:14,211 ERROR [c.c.a.ApiServer] (catalina-exec-1:ctx

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221893016 Maybe you meant to change on this table: `` alter table `vm_template` modify column `url` varchar(2048) DEFAULT NULL COMMENT 'the url wher

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-26 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221876586 @wido I have the 255-chars problems here too, and this particular table is empty; did you add a patch on the API too to unlock the API limitation to 255 chars

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-25 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-221572152 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-24 Thread footplus
Github user footplus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64432411 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -204,6 +203,7 @@ if [ -f "$customCACert" ] then keytool -delete -alias $aliasName

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-24 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-221324378 Hum, please wait a bit before merging, it seems that in certain cases, a problem occurs; I'm not sure yet, but there may be more to it. I'll do

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734 LGTM :) It seems to work correctly on my 4.8.0 setup. Thanks. Best regards, Aurélien --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-22 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-213389763 @swill this is completely a LGTM :) We have this working on CS 4.8 in production. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-03-02 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-191264802 Hello, I was able to confirm this patch works on CloudStack 4.8.0. The only thing is to take care of removing the systemvm-4.8.0.iso from the secondary storage