[GitHub] cloudstack pull request #1925: CLOUDSTACK-9751: Fix public ip not applied, w...

2017-02-01 Thread fmaximus
GitHub user fmaximus opened a pull request: https://github.com/apache/cloudstack/pull/1925 CLOUDSTACK-9751: Fix public ip not applied, when added while VR is starting Public IP state wasn't passed to the vsp client, making it ignore the apply public ip. Bugfix-for

[GitHub] cloudstack pull request #1912: CLOUDSTACK-9749: Disable password service on ...

2017-01-19 Thread fmaximus
GitHub user fmaximus opened a pull request: https://github.com/apache/cloudstack/pull/1912 CLOUDSTACK-9749: Disable password service on ilb systemvm Fix cloud-password-srvr correctly. Made sure it runs on VPC VR, but not on Internal LB You can merge this pull request into a Git

[GitHub] cloudstack issue #1662: Fix bug juniper srx

2017-01-19 Thread fmaximus
Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1662 Seems the fork is gone. I propose we close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1904: Use latest Nuage client.

2017-01-12 Thread fmaximus
GitHub user fmaximus opened a pull request: https://github.com/apache/cloudstack/pull/1904 Use latest Nuage client. CloudStack root pom change to use Amazon WS 11.1.16 caused our client to fail, as it was depending on classes, which are not not present anymore. Latest

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90624351 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90623492 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90623476 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90619259 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90236739 --- Diff: api/src/com/cloud/network/Network.java --- @@ -215,6 +216,8 @@ public static Provider getProvider(String providerName) { public

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-29 Thread fmaximus
Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1579 Rebased and squashed all commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-09-07 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r77851893 --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py --- @@ -631,195 +753,257 @@ def check_Router_state(self, router, state=None

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-09-07 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r77831210 --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py --- @@ -175,45 +234,44 @@ def tearDown(self): return

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-09-07 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r77818579 --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java --- @@ -988,6 +1016,21 @@ public boolean addDhcpEntry(final Network network

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-09-07 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r77800584 --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py --- @@ -77,85 +117,104 @@ def setUpClass(cls, zone=None): cls.test_data

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-08-31 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r76993494 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2645,6 +2669,18 @@ public

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-08-31 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r76991083 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -242,6 +249,40 @@ public void reserve

[GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...

2016-08-31 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1578#discussion_r76991270 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -403,4 +448,25 @@ private HostVO

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

2016-08-24 Thread fmaximus
Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1652 I will make the change. I also plan to only create the vpc offering if there are Nuage VSP devices configured, which makes more sense for the users of CloudStack that do not use our plugin

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

2016-08-22 Thread fmaximus
Github user fmaximus commented on the issue: https://github.com/apache/cloudstack/pull/1652 As Nuage plugin developer, I can't come up with any good reason why it should be default. Also I see that Redundant VPC Offering is set to be a default. Both are most likely just c

[GitHub] cloudstack pull request: CLOUDSTACK-9095 : Hypervisor changes to s...

2015-12-07 Thread fmaximus
Github user fmaximus commented on the pull request: https://github.com/apache/cloudstack/pull/1142#issuecomment-162483085 Are we still taking Travis into account? It has a unit test failure in HypervisorUtilTest, which also failed in other builds on Travis. This test seems to fail

[GitHub] cloudstack pull request: Fix NuageVsp errors for build-master-slow...

2015-11-19 Thread fmaximus
Github user fmaximus commented on the pull request: https://github.com/apache/cloudstack/pull/1092#issuecomment-158100736 I think we should use StringUtils.getUtf8Bytes() instead, as we are using StringUtils.newStringUtf8(Base64.decodeBase64(cmsUserPassBase64)) on the other side