Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1519
@murali-reddy I haven't worked on Cloudstack for many months but one thing
I do recall; without d582358 and bf285e1, networks with redundant virtual
routers will simply not
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1519
PR #1659 appears to have superseded this PR. As such I'm concerned about
recent activity on this PR.
Is anyone available to clarify what should be done? I'd anticipated closin
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@murali-reddy - thank you for picking this up. Let me know when you think
it's appropriate to close PR #1519 and I shall do so.
---
If your project is set up for it, you can reply to
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1568
Unfortunately I won't be available to do further work on this PR. I'll
leave the commits available incase they are useful.
---
If your project is set up for it, you can reply to this
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1519
I'd recommend merging this if the tests are passing. There is an issue with
hairpin NATs which can be solved by adding a route to the guest subnet (scope
link) in each routing table. Th
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1568
@remibergsma @ustcweizhou Well that clears that up! I'll see about
adjusting the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1568#issuecomment-222308460
**NB**: This PR should be considered controversial because it restarts the
password server after each keepalived transition, rather than stopping the
service on
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1568
CLOUDSTACK-9385 - Ensure passwd srvr is restarts after keepalived
transitions
Based on @ustcweizhou code suggestion. Tried on redundant and standalone
virtual routers and works fine
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-222195257
@luhaijiao I'd recommend trying e7a63be
Port forwarding works for me. I've not tried the VPN functionality.
---
If your project is set up for i
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-222085574
@swill agreed; in particular, my note concerning the merge of lines 299 and
300 - i've not even tested that locally - not had a chance to even figure out
what
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-221867807
@swill no worries. Happy to do that - the CI output was vast and I wasn't
looking forward to combing through it.
---
If your project is set up for it, yo
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1519
Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces
This PR addresses CLOUDSTACK-9339 and may need a code review from someone
familiar with the System VM scripts. In
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1519
Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces
This PR addresses CLOUDSTACK-9339 and may need a code review from someone
familiar with the System VM scripts. In
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-221611699
Same issue. I don't think this is related to the PR. I'll leave this be for
now.
---
If your project is set up for it, you can reply to this email and
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-221600590
> No output has been received in the last 10m0s, this potentially indicates
a stalled build or something wrong with the build itself.
>
>The build
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1519
Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces
This PR addresses CLOUDSTACK-9339 and may need a code review from someone
familiar with the System VM scripts. In
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1519
Cloudstack 9339: Virtual Routers do not handle Multiple Public Interfaces
This PR addresses CLOUDSTACK-9339 and may need a code review from someone
familiar with the System VM scripts. In
Github user dsclose commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1519#discussion_r64537215
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -288,14 +290,16 @@ def post_configure(self, address):
"&
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-221501553
@swill taking a look now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221304669
@swill if you are happy to merge this without including the tests requested
by @jburwell then this PR is ready to merge.
@luhaijiao I've created CLOUD
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220982534
@luhaijiao I reverted to a vanilla Cloudstack 4.8.0 ISO. The
cloud-passwd-srvr service failed to start. The following appears in
/var/log/messages on the router
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220964156
@luhaijiao I've seen the same error in our XenServer setup but wasn't sure
what the cause is. I'd be surprised if this was the cause but it
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220918123
@swill
Pardon me - I was on leave for a week. I'll get this force pushed
momentarily.
---
If your project is set up for it, you can reply to this emai
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217495575
@swill ok, thanks, good luck with the master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217490305
Same error over at #1519 - something introduced in an earlier commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217489945
I rebased against the latest 4.7 before force pushing. Has an error been
introduced along the way?
---
If your project is set up for it, you can reply to this
Github user dsclose commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1514#discussion_r62344011
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
self.cloud.commit
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217397801
Looks like the build environment isn't sufficient on jenkins-test-a20:
```
[ERROR] Java HotSpot(TM) 64-Bit Server VM warning: Insufficient spac
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-217392996
@DaanHoogland yes, the line `CsHelper.service("dnsmasq", "restart")` in
`set_master` is in
systemvm/patches/debian/config/opt/cloud/bin/cs/Cs
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217383124
Squashed and force pushed. Tasks remaining:
- [ ] Pass CI
- [ ] Situational testing on VPC RvR
- [ ] Some automated tests
Regarding the
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217290925
@kiwiflyer I have not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217279039
That worked a treat. The suggestions made by @ustcweizhou resulted in a
very clean set of IP rules and I was able to add IPs on eth4 and eth5 without
breaking the
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217110131
Currently I'm investigating @ustcweizhou suggestions above. He's quite
correct about not adding the mark for eth0 and I think I've reproduced
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-215480948
@ustcweizhou How would you recommend I separate this? I can imagine
separating the issues broadly into two parts:
1. **Routing tables and iptables rules
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1519
Cloudstack 9339: Virtual Routers don't handle Multiple Public Interfaces
This PR addresses CLOUDSTACK-9339 and may need a code review from someone
familiar with the System VM script
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-214246821
@jburwell - sure, I should be able to look at that this week. I'll
investigate why the CI build failed as well.
---
If your project is set up for it, yo
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213467207
@swill and thank you for you're support - much appreciated :-)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213465470
Rebased off of 4.7 branch and opened PR #1514 - closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213437832
@swill I raised the PR against `apache:4.7.1-RC20160120T2318` because it
seemed sensible to include it in the latest 4.7 branch. I'd assumed it could be
fo
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1509
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup RvR
CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this
is no-longer accurate, as service monitoring is not
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208755644
@kiwiflyer
I'm currently working on CLOUDSTACK-9339 to resolve the issues that I
mentioned in #1413 - I don't think this PR breaks anything that
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205831656
Thank you. I've raised CLOUDSTACK-9339 on Jira about the non-VPC RvR
issues. As my company needs those issues solved in the short term I'll begin
workin
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205716220
@wilderrodrigues @ustcweizhou Sorry to arrive late to the party but this
appears to break/ignore some RvR functionality. 4 things in particular stand
out
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1063
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-157678223
CLosing this pull request as the patched script is already deprecated.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157672288
@wilderrodrigues I'd be pleased to write a Marvin test though I've not
worked with them before. I think the first step would be to get the tests
run
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1062
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157418578
Closing this pull request now that it has been created against the 4.6
branch in PR #1079
---
If your project is set up for it, you can reply to this email and
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157416663
@wilderrodrigues no, i was asked to open this pull request by @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157411634
This is a duplicate of PR https://github.com/apache/cloudstack/pull/1062
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157411446
I've created the PR against 4.6 now.
https://github.com/apache/cloudstack/pull/1079
---
If your project is set up for it, you can reply to this emai
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1079
CLOUDSTACK-9058 - Respond with "saved_password" if no password is to be
issued.
The password server on the virtual router should respond with
"saved_password" if no pass
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157409534
This was tested situationally. Not perfect, but we don't have the
Cloudstack test-suite setup yet. Not sure I will have time to do that now.
The foll
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-156103338
As with my other pull request, I only used situational tests for this. I'll
look into the docs to get the marvin tests up and running and will update this
iss
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156103018
I've only used situational tests for this fix. I'll looking into the docs
regarding getting the integration tests up and running and will get back to y
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1063
CLOUDSTACK-9050
Changed grep to match IP address only. Solves issue where virtual router
was NATing IP addresses to the wrong interface if the IP address was a
substring of the broadcast
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1062
CLOUDSTACK-9058
Respond with "saved_password" if no password is to be issued.
You can merge this pull request into a Git repository by running:
$ git pull https://github.c
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/commit/59a9db39b1d17056753385c0e091bfe26d2df522#commitcomment-14184110
Issue CLOUDSTACK-9024 refers to this commit.
https://issues.apache.org/jira/browse/CLOUDSTACK-9024
---
If your project
70 matches
Mail list logo
