[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-02-22 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-187342982 LGTM, 4.7.1 with this fix was installed on a live environment with success. Instances can now be migrated to and from the kvm node that has an IP address

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-02-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-182446008 proof that this works in centos 7.2 running cloudstack 4.7.1: ``` # cat /etc/redhat-release CentOS Linux release 7.2.1511 (Core

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-02-10 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1409 CLOUDSTACK-9283: add pid to java arguments in cloudstack-usage.service cloudstack-usage fails to start throwing Integer exception during PID retrieval, and the service keeps

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

2016-01-12 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-170898189 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2016-01-05 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-169104666 LGTM, but haven't had the chance to test it yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...

2015-11-30 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1008#issuecomment-160594088 @bhaisaab I see no harm in trying to package 4.5 with this spec. It should just work (read, services start) if all the files expected by the spec file are

[GitHub] cloudstack pull request:

2015-11-24 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/commit/e66dd8c1e00abb9a3b4cbe0b8b50c83b251a728c#commitcomment-14604799 https://github.com/apache/cloudstack/pull/1114 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9065: fix bug when creating pa...

2015-11-24 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1114 CLOUDSTACK-9065: fix bug when creating packaging with noredist flag You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request:

2015-11-24 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/commit/e66dd8c1e00abb9a3b4cbe0b8b50c83b251a728c#commitcomment-14604451 Found the offending bit. It is missing double quotes surrounding that variable in line 105. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-18 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1075#issuecomment-157647291 As for installing the package, having distinct package version numbers allows one to update packages instead of having to remove and install them in

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-18 Thread davidamorimfaria
Github user davidamorimfaria commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1075#discussion_r45172947 --- Diff: packaging/package.sh --- @@ -18,26 +18,37 @@ function usage() { echo "" -echo "usage: .

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-18 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1075#issuecomment-157643811 This is the package release version number, nothing to do with the thing that is packaged. Its purpose is to allow for this script to be used with

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-16 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1075#issuecomment-157133142 `package.sh -d centos7 -r 3` (...) `Wrote: /root/cloudstack-packaging_release_version/dist/rpmbuild/RPMS/x86_64/cloudstack-management-4.6.0

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-16 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1075 CLOUDSTACK-9065: Packaging RPM, add option for package release version, cleanup and lint In package.sh * lint * adjust exit codes (1 for usage, 2 for maven, 3 for rpmbuild

[GitHub] cloudstack pull request: Add package release version option to RPM...

2015-11-16 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1074#issuecomment-157114580 closed pr, needs extra testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Add package release version option to RPM...

2015-11-16 Thread davidamorimfaria
Github user davidamorimfaria closed the pull request at: https://github.com/apache/cloudstack/pull/1074 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Add package release version option to RPM...

2015-11-16 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1074 Add package release version option to RPM packaging script Add package release version option to RPM packaging script, and do some needed linting and code refactoring. You can merge

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155389434 squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155371923 added pr for docs-install https://github.com/apache/cloudstack-docs-install/pull/24 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack-docs-install pull request: include argument for tomcat7...

2015-11-10 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack-docs-install/pull/24 include argument for tomcat7 servlet container include argument for tomcat7 servlet container during management server setup You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155356678 Just tested and managed to deploy the management server without issues. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155349621 The mess has been sorted and the code is ready for testing. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
GitHub user davidamorimfaria reopened a pull request: https://github.com/apache/cloudstack/pull/1052 CLOUDSTACK-9049: fix Centos7 with Tomcat7 packaging and python libs CLOUDSTACK-9049: Fix Centos7 with Tomcat7 packaging and python libs You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria closed the pull request at: https://github.com/apache/cloudstack/pull/1052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155134956 I haven't tested these changes yet, hopefully will have time tomorrow to do it. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-09 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1052 CLOUDSTACK-9049: fix Centos7 with Tomcat7 packaging and python libs CLOUDSTACK-9049: Fix Centos7 with Tomcat7 packaging and python libs You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-09 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155010677 I will have a chance to test it this week --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...

2015-10-31 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1008#issuecomment-152712182 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9010: adjust packaging for cen...

2015-10-30 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1008#issuecomment-152536728 I haven't installed a cloud with the packages made with this change, but so far the management servers start and talk to each other: Oct 30

[GitHub] cloudstack pull request: adjust packaging for centos7

2015-10-29 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1008 adjust packaging for centos7 Here are a few adjustments for the packaging in centos7. With these changes I was able to start the service. Please review. Thank you. You can merge