Re: Review Request 14889: Expose as much type information to commands.xml as well as to the generated python clasesss for Marvin

2013-10-28 Thread Ryan Dietrich
> > use the type info to deserialize the response returned by the server so > > each field gets its appropriate type. But in most tests we don't use the > > type information afaik. > > Ryan Dietrich wrote: > Yes, a carrier. The main goal was to get the type

Re: Review Request 14889: Expose as much type information to commands.xml as well as to the generated python clasesss for Marvin

2013-10-28 Thread Ryan Dietrich
views.apache.org/r/14889/#review27593 --- On Oct. 23, 2013, 9:38 p.m., Ryan Dietrich wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 14889: Expose as much type information to commands.xml as well as to the generated python clasesss for Marvin

2013-10-25 Thread Ryan Dietrich
ot;things" could take advantage of this extra meta-data. - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14889/#review27513 ----

Re: Review Request 14889: Expose as much type information to commands.xml as well as to the generated python clasesss for Marvin

2013-10-23 Thread Ryan Dietrich
cd tools/apidoc mvn inspect target/commands.xml cd ../tools/marvin mvn inspect python classes Thanks, Ryan Dietrich

Review Request 14889: Expose as much type information to commands.xml as well as to the generated python clasesss for Marvin

2013-10-23 Thread Ryan Dietrich
oc/ApiXmlDocWriter.java c3c0cab server/src/com/cloud/api/doc/Argument.java 29c361e tools/marvin/marvin/codegenerator.py 96729f6 Diff: https://reviews.apache.org/r/14889/diff/ Testing --- mvn clean mvn cd tools/apidoc mvn inspect target/commands.xml cd ../tools/marvin mvn inspect python classes Thanks, Ryan Dietrich

Re: Review Request 12752: Async commands can inject the job id

2013-07-19 Thread Ryan Dietrich
c Diff: https://reviews.apache.org/r/12752/diff/ Testing --- Updated marvin, updated the deploy vm test. Ran multiple async commands manually, with and without injectedjobid present, no issues detected. Thanks, Ryan Dietrich

Re: Review Request 12752: Async commands can inject the job id

2013-07-18 Thread Ryan Dietrich
reply, visit: https://reviews.apache.org/r/12752/#review23457 --- On July 18, 2013, 11:28 p.m., Ryan Dietrich wrote: > > --- > This is an automatically generated e-mail. T

Review Request 12752: Async commands can inject the job id

2013-07-18 Thread Ryan Dietrich
s/marvin/marvin/codegenerator.py 632b8c6 tools/marvin/marvin/integration/lib/base.py 161d03c Diff: https://reviews.apache.org/r/12752/diff/ Testing --- Updated marvin, updated the deploy vm test. Ran multiple async commands manually, with and without injectedjobid present, no issues detected.

Re: Review Request 12223: Async jobs actions now trigger event bus messages to be published

2013-07-03 Thread Ryan Dietrich
diff/ Testing --- Manual testing only at this point. I am more than willing to write a python test using marvin, but I'm unsure if marvin has rabbitmq library support or not yet. Please advise. Thanks, Ryan Dietrich

Re: Review Request 12223: Async jobs actions now trigger event bus messages to be published

2013-07-03 Thread Ryan Dietrich
nge. - Ryan ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12223/#review22704 --- On July 3, 2013, 2:17 p.m., Ryan Dietrich wrote: > &g

Re: Async Job / Event Bus issue

2013-07-02 Thread Ryan Dietrich
Ok. I see the "reset attached object" calls now. I'm curious why those columns are being wiped out. If you wanted to see outstanding calls for an ID or Type, wouldn't you just query where the jobStatus is still equal to zero? Wiping out those columns seems to destroy history, no? On Jul 2, 2

Async Job / Event Bus issue

2013-07-02 Thread Ryan Dietrich
e volumes when it queries the AsyncJobVO back out (and subsequently updates the columns with null values), or it's something that I'm simply not seeing. Help? On Jul 2, 2013, at 8:15 AM, Ryan Dietrich wrote: > Patch submitted. > > https://reviews.apache.org/r/12223/ >

Re: event bus details

2013-07-02 Thread Ryan Dietrich
arguments passed in from the user. I went with the APIDBUtils query function for UUID's because I saw no precedent for accessing that HashMap after initial argument handling. -Ryan Dietrich

Re: event bus details

2013-06-27 Thread Ryan Dietrich
id":"ed51b63b-a63b-4e6a-8c36-45f32c29988d","old-state":"Destroy","new-state":"Destroy","resource":"Volume"} So, it would appear that three messages are generated when deleting a volume. A resource change, a usage event, and then a resource change confirmation. If I follow things up in the log, I see what triggers it. management-server.ActionEvent.VM-DESTROY.VirtualMachine.* {"status":"Scheduled","event":"VM.DESTROY","account":"f66d4d60-bbdf-11e2-8bb5-52540014c04d","user":"f66f14d8-bbdf-11e2-8bb5-52540014c04d"} Based on this, I'm not sure UsageEvent is actually adding any value. Worse, there is no way to tie the resource events to the action event that kicked those subordinate actions off. Let me know how you'd like to proceed on these issues. -Ryan Dietrich

Re: event bus details

2013-06-26 Thread Ryan Dietrich
aging (currently it seems every message being pushed out to RabbitMQ follows a different format). Is there any documentation or plan for this system going forward? I need this working, now-ish, so I'm willing to get in and get it done, but again, I'd rather work with the flow, and no

Re: Review Request: When associating an IP to a VPC allow admin's to specify what IP they want to associate. (CLOUDSTACK-1942)

2013-04-12 Thread Ryan Dietrich
ell as 4.1. Tested manually using "ipid" as well as leaving it off resulting in existing functionality. Also, ran new marvin test. This probably could have been incorporated into the the existing test_network.py file, but half of those tests were failing on my system. Thanks, Ryan Dietrich

Re: [ACS41] Help needed clearing bugs!

2013-04-11 Thread Ryan Dietrich
Could you look at this first? https://reviews.apache.org/r/10426/ On Apr 11, 2013, at 6:25 PM, Prachi Damle wrote: > I will take a look at CLOUDSTACK-1987. > > -Prachi > > -Original Message- > From: Edison Su [mailto:edison...@citrix.com] > Sent: Thursday, April 11, 2013 5:17 PM > To

Re: [ACS41] Help needed clearing bugs!

2013-04-11 Thread Ryan Dietrich
I believe I have a fix for CLOUDSTACK-1987. https://reviews.apache.org/r/10426/ On Apr 11, 2013, at 3:40 PM, Kelven Yang wrote: > about CLOUDSTACK-1978, it looks like the problem at hypervsor host side, > the hypervisor host is either failed to setup the VNC listening interface > or failed to c

Associate IP feature request (RE: CLOUDSTACK-1942)

2013-04-10 Thread Ryan Dietrich
now, otherwise I'll be happy to post the diff to review board. Thanks, -Ryan Dietrich

Re: Plugin woes...

2013-04-04 Thread Ryan Dietrich
I went ahead and updated the wiki with an example. Feel free to add/remove/edit what I've written. -Ryan Dietrich On Apr 4, 2013, at 6:12 PM, Kelven Yang wrote: > We removed auto-scanning recently and we need to update related > documentation as well on guidelines to program com

Re: Plugin woes...

2013-04-04 Thread Ryan Dietrich
Ok, it works now. I just had to add: to client/tomcatconf/componentContext.xml.in I'll wait for Kelven to update the xml in 4.1, and then I'll pretty up my example plugin and update the wiki. Thank you all for your assistance. -Ryan Dietrich On Apr 4, 2013, at 3:00 PM,

Re: Plugin woes...

2013-04-04 Thread Ryan Dietrich
> > On 4/4/13 1:24 PM, "Alex Huang" wrote: > >> Ryan, >> >> Did you add it to componentscontext.xml? >> >> --Alex >> >>> -Original Message- >>> From: Ryan Dietrich [mailto:r...@betterservers.com] >>&

Re: Plugin woes...

2013-04-04 Thread Ryan Dietrich
Alex Huang wrote: > Ryan, > > Did you add it to componentscontext.xml? > > --Alex > >> -----Original Message- >> From: Ryan Dietrich [mailto:r...@betterservers.com] >> Sent: Thursday, April 4, 2013 1:16 PM >> To: dev@cloudstack.apache.org >>

Re: Plugin woes...

2013-04-04 Thread Ryan Dietrich
Oh, I should mention I did this on the 4.1 branch. On Apr 4, 2013, at 2:10 PM, Ryan Dietrich wrote: > I have written a test plugin, but it is not being picked up by spring. > > Specifically, I am looking at ApiDiscoveryServiceImpl.java > >@Inject protected List _servic