Re: Review Request 16337: [CLOUDSTACK-5526] Fix LibvirtDomainXMLParser error when diskCacheMode is empty string

2014-02-18 Thread Howie YU
er.java 9cf6a90 Diff: https://reviews.apache.org/r/16337/diff/ Testing --- Thanks, Howie YU

Re: Review Request 16461: CLOUDSTACK-5642 - Add else if connidition for identify direct nic type

2014-02-18 Thread Howie YU
LParserTest in test directory , and add a direct nic type domain xml for test ubuntu 77919cf3-b2a7-994f-5f3c-0a91fb9bcbe8 1048576 1048576 1 hvm destroy restart restart /usr/libexec/qemu-kvm Thanks, Howie YU

Review Request 16461: CLOUDSTACK-5642 - Add else if connidition for identify direct nic type

2013-12-24 Thread Howie YU
/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParserTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16461/diff/ Testing --- I add a unit test LibvirtDomainXMLParserTest in test directory , and add a direct nic type domain xml for test ubuntu 77919cf3-b2a7-994f-5f3c-0a91fb9bcbe8 1048576 1048576 1 hvm destroy restart restart /usr/libexec/qemu-kvm Thanks, Howie YU

Re: Review Request 16337: [CLOUDSTACK-5526] Fix LibvirtDomainXMLParser error when diskCacheMode is empty string

2013-12-24 Thread Howie YU
ff/ Testing --- Thanks, Howie YU

Review Request 16337: [CLOUDSTACK-5526] Fix LibvirtDomainXMLParser error when diskCacheMode is empty string

2013-12-17 Thread Howie YU
ef.diskCacheMode.NONE); } else { def.setCacheMode(DiskDef.diskCacheMode.valueOf(diskCacheMode)); } Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java 127f648 Diff: https://reviews.apache.org/r/16337/diff/ Testing --- Thanks, Howie YU