er.java
9cf6a90
Diff: https://reviews.apache.org/r/16337/diff/
Testing
---
Thanks,
Howie YU
LParserTest in test directory , and add a
direct nic type domain xml for test
ubuntu
77919cf3-b2a7-994f-5f3c-0a91fb9bcbe8
1048576
1048576
1
hvm
destroy
restart
restart
/usr/libexec/qemu-kvm
Thanks,
Howie YU
Hi Wei
Ok~ Let me check it.
After applied should I cerate a new review or just update it ?
2014-02-18 20:31 GMT+08:00 Wei Zhou :
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16461/
>
> Howie,
> Could you change it as it can no
= getAttrValue("source", "bridge", nic);
def.defBridgeNet(bridge, dev, mac,
nicModel.valueOf(model.toUpperCase()), networkRateKBps);
} else if (type.equalsIgnoreCase("ethernet")) {
String scriptPath = getAttrValue("script", "path", nic);
def.defEthernet(dev, mac,
nicModel.valueOf(model.toUpperCase()), scriptPath, networkRateKBps);
}
interfaces.add(def);
Howie
= getAttrValue("source", "bridge", nic);
def.defBridgeNet(bridge, dev, mac,
nicModel.valueOf(model.toUpperCase()), networkRateKBps);
} else if (type.equalsIgnoreCase("ethernet")) {
String scriptPath = getAttrValue("script", "path", nic);
def.defEthernet(dev, mac,
nicModel.valueOf(model.toUpperCase()), scriptPath, networkRateKBps);
}
interfaces.add(def);
Howie
/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParserTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/16461/diff/
Testing
---
I add a unit test LibvirtDomainXMLParserTest in test directory , and add a
direct nic type domain xml for test
ubuntu
77919cf3-b2a7-994f-5f3c-0a91fb9bcbe8
1048576
1048576
1
hvm
destroy
restart
restart
/usr/libexec/qemu-kvm
Thanks,
Howie YU
ff/
Testing
---
Thanks,
Howie YU
ef.diskCacheMode.NONE);
} else {
def.setCacheMode(DiskDef.diskCacheMode.valueOf(diskCacheMode));
}
Diffs
-
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
127f648
Diff: https://reviews.apache.org/r/16337/diff/
Testing
---
Thanks,
Howie YU
