Re: [PR] Allow setting of source CIDR for LB rule [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
CodeBleu commented on PR #78: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/78#issuecomment-3576953849 > Code looks good. But it doesn't handle when the CIDR list is updated in the annotation. This is because that API didn't exist when the PR was first created. -

Re: [PR] Allow setting of source CIDR for LB rule [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 commented on PR #78: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/78#issuecomment-3576360580 Code looks good. But it doesn't handle when the CIDR list is updated in the annotation. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Update debugging docs, GitHub Actions and golangci config [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
Copilot commented on code in PR #84: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/84#discussion_r2560510005 ## .golangci.yml: ## @@ -1,53 +1,46 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See

[PR] Update debugging docs, GitHub Actions and golangci config [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 opened a new pull request, #84: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/84 This pull request updates the project's development tooling and documentation to improve compatibility, maintainability, and developer experience. The most significant changes are

Re: [PR] Allow custom region from config [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
Copilot commented on code in PR #83: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/83#discussion_r2560173545 ## cloudstack.go: ## @@ -234,7 +238,14 @@ func (cs *CSCloud) GetZoneByNodeName(ctx context.Context, nodeName types.NodeNam klog.V(2).Info

Re: [I] Need docker image build for arm64 platform [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 closed issue #80: Need docker image build for arm64 platform URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Add support for arm64 image [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 merged PR #81: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

Re: [PR] Allow custom region from config [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
Copilot commented on code in PR #83: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/83#discussion_r2560016685 ## cloudstack.go: ## @@ -190,7 +193,12 @@ func (cs *CSCloud) GetZone(ctx context.Context) (cloudprovider.Zone, error) { klog.V(2).Infof("

[PR] Allow custom region from config [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 opened a new pull request, #83: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/83 Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/39 Details This pull request introduces support for a configurable `region` parameter in the

Re: [PR] Add support for arm64 image [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 commented on code in PR #81: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/81#discussion_r2559854070 ## .github/workflows/build-docker-image.yml: ## @@ -57,8 +50,41 @@ jobs: - name: Set Docker image FULL TAG run: echo "FULL_TAG=$(i

Re: [PR] Add support for arm64 image [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 commented on code in PR #81: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/81#discussion_r2559853290 ## .github/workflows/build-docker-image.yml: ## @@ -34,16 +34,9 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstac

Re: [PR] Associate loadBalancerIP to the network when specified in the Spec [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
Copilot commented on code in PR #82: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/82#discussion_r2559828323 ## cloudstack_loadbalancer.go: ## @@ -127,6 +133,14 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context, clusterName string, s

[PR] Associate loadBalancerIP to the network when specified in the Spec [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
vishesh92 opened a new pull request, #82: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/82 Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/51 Details This pull request introduces enhancements to the CloudStack cloud provider for Ku

Re: [PR] Add support for arm64 image [cloudstack-kubernetes-provider]

2025-11-25 Thread via GitHub
Pearl1594 commented on code in PR #81: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/81#discussion_r2559799599 ## .github/workflows/build-docker-image.yml: ## @@ -34,16 +34,9 @@ concurrency: jobs: build: -if: github.repository == 'apache/cloudstac

Re: [DEPRECATE] retire tools/ngui (Angular UI)

2025-11-25 Thread Rohit Yadav
+1 should we able to remove this. This does not need deprecation as this was an unfinished GSoC student project which was never claimed to be shipped/used/released. Regards. From: João Jandre Paraquetti Sent: Tuesday, November 11, 2025 17:27 To: dev@cloudstack

Re: [DEPRECATE] retire the hyperv plugin

2025-11-25 Thread Rohit Yadav
+1 the old / .net-C# one was broadly supported for a limited time and didn't get much maintenance over the years. Now that the Hyper-V extension is here, we should be safely able to retire the java-based plugin. Regards. From: Vishesh Jindal Sent: Tuesday, No

Re: [DEPRECATE] retire UCS hypervisor plugin

2025-11-25 Thread Rohit Yadav
+1 we should be able to deprecate them and eventually remove them. Many storage/hypervisor/network plugins were created as PoC and were only broadly supported without much depth. UCS was one of them, and it's likely it does not work and the s/w - h/w stack is deprecated / vendor EOL'd. We should

Re: New PMC member: Vishesh Jindal

2025-11-25 Thread Rohit Yadav
Congratulations Vishesh - well deserved! Regards. From: Vishesh Sent: Tuesday, November 11, 2025 11:32 To: [email protected] Cc: [email protected] Subject: Re: New PMC member: Vishesh Jindal Thank you everyone! Regards Vishesh On Fri, Nov

Re: [DEPRECATE] retire the OVM plugins

2025-11-25 Thread Rohit Yadav
+1 to deprecate and remove the codebase OVM/OVM3 was quickly killed off as products, we can be certain nobody is using them and they aren't been maintained for years now. Regards. From: Daan Hoogland Sent: Tuesday, November 11, 2025 12:44 To: dev Cc: PMC ; us